Pending

User tests: Successful: Unsuccessful:

avatar pixelhexe
pixelhexe
28 Nov 2024

Pull Request for Issue #44549 .

Summary of Changes

Add option to finder plugin "Smart Search - Content" for excluding search for author's name in article field "created by".

finder-new-option

Testing Instructions

You'll need some articles written by an author and in one or several articles insert the author's name as normal content (article text). Add a finder / smart search into your site as you would generally do. For example add a menu item with menu item type "Search" without special filters or advanced features. Don't forget to index your content in backend in the search component.

After the changes of this pull request you'll have an additional option in the finder plugin content "Include articles 'created by' (author's name)?" with default value "yes". Everything remains as it is if this option is not changed.

For testing purposes switch the new option to "no" and save it. Then you'll need to clear your search index and reindex content.

In frontend, search for the author's name which you included in the article text of one or more articles.

Actual result BEFORE applying this Pull Request

The search results will show all articles created by this author.

Users are confused because they don't know how these search results come about - unless the site is configured so that the authors are always visible in the articles, which is often not the case.
They would expect only those articles to be listed where the author's name appears in the normal article text.

Expected result AFTER applying this Pull Request

The search results will only show those articles in which the author's name is included in the article content text.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar pixelhexe pixelhexe - open - 28 Nov 2024
avatar pixelhexe pixelhexe - change - 28 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2024
Category Administration Language & Strings Front End Plugins
avatar jsubri jsubri - test_item - 30 Nov 2024 - Tested successfully
avatar jsubri
jsubri - comment - 30 Nov 2024

I have tested this item ✅ successfully on be0a12b

Tested on top of 5.2.2.
With the xml default="1" we are having the current behaviour, with the plugin set to "No" the Article's Author are no longer displayed.
Nice fix.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44554.

avatar Hackwar
Hackwar - comment - 1 Dec 2024

The way you implemented this, this definitely is a new feature and needs to go into 5.3. I'm going to discuss this in the CMS maintenance team if we expect the existing option for the taxonomy to also remove this from the search index. In that case this might be considered a bug and can be fixed in 5.2. In any case I'd like to see this handled for all things we are adding to the index (author, category, tags) and for all core finder plugins.

avatar Hackwar
Hackwar - comment - 16 Jan 2025

I'm sorry, but I will have to handle this as a new feature and as I said, I would need more than just one "random" part of the article to be able to be switched off. I'm moving this to 5.3 for now and will switch the label to feature instead. Please change it as I described above.

Add a Comment

Login with GitHub to post a comment