[#44530] - Update PackageAdapter.php
- Pending
- Medium
- Build: 5.2-dev
- # 44530
- Diff
- BrainforgeUK:patch-30
User tests: Successful: Unsuccessful:
Remove whitespace around extension folder names.
Pull Request for Issue # .
Replacement for pull request 40989.
Summary of Changes
Apply trim() function to filename.
An alternative solution would be to remove the whitespace in the manifest.
But why? It is valid XML and the installation failure can catch extension developers by surprise.
Testing Instructions
Install attached test package.
test1.zip
Actual result BEFORE applying this Pull Request
Package installation fails.
Expected result AFTER applying this Pull Request
Package installation succeeds
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
An alternative solution would be to remove the whitespace in the manifest.
But why? It is valid XML and the installation failure can catch extension developers by surprise.
Yes, it is valid XML having new lines inside XML element values.
But the XML standard also makes clear that EVERYTHING between the element's opening and closing tag belongs to the value, and that means also the line feeds or whatever else there is.
And that means that the extension's manifest is wrong if it adds something (line feeds) to the value which should not be there.
The existing code is correct. Joomla cannot and should not try to fix problems in other peoples code. An extension developer will obviously test their own code before they release it.