Feature PR-5.3-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar brianteeman
brianteeman
28 Nov 2024

In the Language Code plugin it is possible to change the code used for a specified language. eg fr-FR can be changed to fr-CA

However everywhhere in the admin that associations are displayed it uses the original code and not the changed code.

This PR is a "takeover" of the original PR #37289 created by @infograf768

That PR has merge conflicts and @infograf768 is now retired.

See the original PR for more screenshots

Testing Instructions

Create a multilingual site.
Enable the languagecode system plugin and give a new lang tag value for a language.

image

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 28 Nov 2024
avatar brianteeman brianteeman - change - 28 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Nov 2024
Category Administration com_associations com_categories com_contact com_content com_menus com_newsfeeds Modules
avatar fgsw fgsw - test_item - 28 Nov 2024 - Tested successfully
avatar fgsw
fgsw - comment - 28 Nov 2024

I have tested this item ✅ successfully on 8ccef0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44551.

avatar brianteeman brianteeman - change - 28 Nov 2024
Labels Added: Feature PR-5.3-dev
avatar Fedik
Fedik - comment - 29 Nov 2024

The feature maybe is good and usefull.
However the implementation is questionable, because hardcoding if (PluginHelper::isEnabled('system', 'languagecode')) everywhere promisses a loot of fun bugs.

Need to look for a better way of doing the same, maybe some extra event, or kind of that.

avatar universewrld
universewrld - comment - 29 Nov 2024

@brianteeman will it work if instead of en-GB i just use en?
in your screenshots it is shown only for language+country codes.

avatar brianteeman
brianteeman - comment - 29 Nov 2024

@brianteeman will it work if instead of en-GB i just use en? in your screenshots it is shown only for language+country codes.

yes but then then language code wont work as intended.

Add a Comment

Login with GitHub to post a comment