[#44550] - [5.3] Actionlogs User filter
- Fixed in Code Base
- 3 Dec 2024
- Medium
- Build: 5.3-dev
- # 44550
- Diff
- brianteeman:logcreator
User tests: Successful: Unsuccessful:
Loading all the users how have ever made an action in a gigantic list is non-performant on a site with a large number of users.
This PR changes the field to a user select. The downside is that you could select a user who has not made any actions but that is outweighed by the performace gain
Pull Request for Issue #43406
Summary of Changes
This pull request includes a deprecation notice for the LogcreatorField class in the administrator/components/com_actionlogs/src/Field/LogcreatorField.php file. The class is marked for removal in version 7.0.
Deprecation notice:
administrator/components/com_actionlogs/src/Field/LogcreatorField.php: Added a deprecation notice indicating that theLogcreatorFieldclass will be removed in version 7.0 and is no longer used.
Testing Instructions
Test that you can still select a user to filter by in the action logs
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
I have tested this item ✅ successfully on 3137785
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44550.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44550.
The downside is that you could select a user who has not made any actions
@brianteeman The other downside is that you can't select a user who once had made any actions and later has been deleted. I'm not sure though if that would be a valid use case, and I haven't checked if that would work without your PR.
I just checked and without this PR the deleted user will not appear in the filter - so no change of behaviour with this PR
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-12-03 13:54:51 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
RTC
|
||
Thanks
thanks
I have tested this item ✅ successfully on 3137785
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44550.