User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Fix PHPCS failing in Drone for the last commit in the 5.2-dev branch:
1) administrator/components/com_scheduler/src/Table/TaskTable.php (nullable_type_declaration_for_default_null_value)
---------- begin diff ----------
--- /drone/src/administrator/components/com_scheduler/src/Table/TaskTable.php
+++ /drone/src/administrator/components/com_scheduler/src/Table/TaskTable.php
@@ -193,7 +193,7 @@
*
* @since __DEPLOY_VERSION__
*/
- protected function _getAssetParentId(Table $table = null, $id = null): int
+ protected function _getAssetParentId(?Table $table = null, $id = null): int
{
$assetId = null;
$asset = new Asset($this->getDbo(), $this->getDispatcher());
----------- end diff -----------
The error was introduced by the merged PR #42493 .
The doc block of that method is already correct for a nullable parameter.
Check that PHPCS succeeds in Drone for this PR.
Check if creating a new task still works and if an asset is created for that task in the same way as without this PR regarding the parent asset.
See https://ci.joomla.org/joomla/joomla-cms/80596/1/7 .
PHPCS succeeds. Nullable parameter is right.
Please select:
No documentation changes for docs.joomla.org needed
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Administration |
Labels |
Added:
PR-5.2-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-28 08:02:34 |
Closed_By | ⇒ | Hackwar |
Thanks for this fix!
I have tested this item ✅ successfully on 91e966d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44543.