PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
27 Nov 2024

Pull Request for Issue # .

Summary of Changes

Fix PHPCS failing in Drone for the last commit in the 5.2-dev branch:

   1) administrator/components/com_scheduler/src/Table/TaskTable.php (nullable_type_declaration_for_default_null_value)
      ---------- begin diff ----------
--- /drone/src/administrator/components/com_scheduler/src/Table/TaskTable.php
+++ /drone/src/administrator/components/com_scheduler/src/Table/TaskTable.php
@@ -193,7 +193,7 @@
      *
      * @since   __DEPLOY_VERSION__
      */
-    protected function _getAssetParentId(Table $table = null, $id = null): int
+    protected function _getAssetParentId(?Table $table = null, $id = null): int
     {
         $assetId = null;
         $asset   = new Asset($this->getDbo(), $this->getDispatcher());

      ----------- end diff -----------

The error was introduced by the merged PR #42493 .

The doc block of that method is already correct for a nullable parameter.

Testing Instructions

Check that PHPCS succeeds in Drone for this PR.

Check if creating a new task still works and if an asset is created for that task in the same way as without this PR regarding the parent asset.

Actual result BEFORE applying this Pull Request

See https://ci.joomla.org/joomla/joomla-cms/80596/1/7 .

Expected result AFTER applying this Pull Request

PHPCS succeeds. Nullable parameter is right.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 27 Nov 2024
avatar richard67 richard67 - change - 27 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2024
Category Administration
avatar richard67 richard67 - change - 27 Nov 2024
The description was changed
avatar richard67 richard67 - edited - 27 Nov 2024
avatar richard67 richard67 - change - 27 Nov 2024
Labels Added: PR-5.2-dev
avatar richard67 richard67 - change - 27 Nov 2024
The description was changed
avatar richard67 richard67 - edited - 27 Nov 2024
avatar alikon alikon - test_item - 28 Nov 2024 - Tested successfully
avatar alikon
alikon - comment - 28 Nov 2024

I have tested this item ✅ successfully on 91e966d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44543.

avatar Hackwar Hackwar - change - 28 Nov 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-28 08:02:34
Closed_By Hackwar
avatar Hackwar Hackwar - close - 28 Nov 2024
avatar Hackwar Hackwar - merge - 28 Nov 2024
avatar Hackwar
Hackwar - comment - 28 Nov 2024

Thanks for this fix!

Add a Comment

Login with GitHub to post a comment