NPM Resource Changed bug PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar SheikhZaeem
SheikhZaeem
26 Nov 2024

Pull Request for Issue #44293 .

Fixes

Fixes #44293

Summary of Changes

Fix dark mode issue in the compare view by adjusting the background color for added and removed text to be more accessible.

Testing Instructions

  1. Enable dark mode.
  2. Compare two versions of an article.
  3. Verify visibility of added (green) and removed (red) text.

Actual result BEFORE applying this Pull Request

The added and removed text is not readable in dark mode.

Expected result AFTER applying this Pull Request

Added text has a green background, and removed text has a red background, both readable in dark mode.

avatar SheikhZaeem SheikhZaeem - open - 26 Nov 2024
avatar SheikhZaeem SheikhZaeem - change - 26 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2024
Category JavaScript Repository NPM Change
avatar SheikhZaeem SheikhZaeem - change - 26 Nov 2024
The description was changed
avatar SheikhZaeem SheikhZaeem - edited - 26 Nov 2024
avatar brianteeman
brianteeman - comment - 26 Nov 2024

Thank you for your contribution.

Please can you ed8it the title so that it is more meaningful - especially as it will be shown in the changelog

image

avatar Quy
Quy - comment - 26 Nov 2024

Please change colors to match the Save / Close buttons. The white text on fluorescent green is difficult to read.

avatar SheikhZaeem SheikhZaeem - change - 27 Nov 2024
Title
Pull Request for Issue #44293
Improve dark mode readability in compare view
avatar SheikhZaeem SheikhZaeem - edited - 27 Nov 2024
avatar SheikhZaeem SheikhZaeem - change - 13 Dec 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-12-13 17:39:12
Closed_By SheikhZaeem
Labels Added: NPM Resource Changed bug PR-5.2-dev
avatar SheikhZaeem SheikhZaeem - close - 13 Dec 2024

Add a Comment

Login with GitHub to post a comment