RTC NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
26 Nov 2024

Pull Request for Issue #42357 .

Summary of Changes

The email validation was changed in #12835 to fix the validation so that an email with a ' was accepted and that an email with a ` was not accepted.

It looks like when this script was changed to es6 (?) the fix was lost.

This PR simply restores that fix

Testing Instructions

Create a user with the following email address DeloresO'Grady@example.com

This PR changes a js file so you either need to test with a prebuilt package OR npm run build:js

Actual result BEFORE applying this Pull Request

User not created with an invalid email message

Expected result AFTER applying this Pull Request

User created

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 26 Nov 2024
avatar brianteeman brianteeman - change - 26 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2024
Category JavaScript Repository NPM Change
avatar Quy Quy - test_item - 26 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 26 Nov 2024

I have tested this item ✅ successfully on b6a462a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44527.

avatar fgsw fgsw - test_item - 27 Nov 2024 - Tested successfully
avatar fgsw
fgsw - comment - 27 Nov 2024

I have tested this item ✅ successfully on b6a462a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44527.

avatar alikon alikon - change - 27 Nov 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 27 Nov 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44527.

avatar Hackwar Hackwar - change - 27 Nov 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-11-27 14:00:16
Closed_By Hackwar
Labels Added: RTC NPM Resource Changed PR-5.2-dev
avatar Hackwar Hackwar - close - 27 Nov 2024
avatar Hackwar Hackwar - merge - 27 Nov 2024
avatar Hackwar
Hackwar - comment - 27 Nov 2024

Thank you for your contribution!

avatar brianteeman
brianteeman - comment - 27 Nov 2024

Thanks

Add a Comment

Login with GitHub to post a comment