Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
22 Nov 2024

Pull Request for Issue # .

Summary of Changes

TinyMCE prints a warning about incorect value for joomlaExtButtons, when all buttons is disabled.
The PR is fixing it, by allowing the empty array of buttons.

Testing Instructions

run npm install
Edit


and set buttons="false"
Open Browser Dev console, and open any article for editing.

Actual result BEFORE applying this Pull Request

Console warning: Invalid value passed for the joomlaExtButtons option. The value must be a object.

Expected result AFTER applying this Pull Request

No warning

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 22 Nov 2024
avatar Fedik Fedik - change - 22 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2024
Category JavaScript Repository NPM Change

Add a Comment

Login with GitHub to post a comment