Feeling Lucky
RTC
NPM Resource Changed
bug
PR-5.2-dev
[#44507] - Fix joomlaExtButtons TinyMCE plugin, buttons validation
- Fixed in Code Base
- 27 Nov 2024
- Medium
- Build: 5.2-dev
- # 44507
- Diff
- Fedik:tinymce-extbtn-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
TinyMCE prints a warning about incorect value for joomlaExtButtons, when all buttons is disabled.
The PR is fixing it, by allowing the empty array of buttons.
Testing Instructions
run npm install
Edit
and set
buttons="false"Open Browser Dev console, and open any article for editing.
Actual result BEFORE applying this Pull Request
Console warning: Invalid value passed for the joomlaExtButtons option. The value must be a object.
Expected result AFTER applying this Pull Request
No warning
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Title |
|
||||||
alikon
- comment
- 27 Nov 2024
I have tested this item ✅ successfully on 2d2529c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44507.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 27 Nov 2024
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44507.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-27 13:58:58 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
RTC
NPM Resource Changed
bug
PR-5.2-dev
|
||
Hackwar
- comment
- 27 Nov 2024
Thanks for your contribution!
I have tested this item ✅ successfully on 2d2529c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44507.