User tests: Successful: 0 Unsuccessful: 0
Pull Request for Issue # .
This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script.
Install this PR
Do the same again.
All should work.
All should work as before.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: WIP
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
PR-5.3-dev
|
Labels |
Added:
Feature
|
Category | Libraries | ⇒ | Unit Tests Repository SQL Administration com_admin Postgresql com_users Language & Strings Modules JavaScript NPM Change Front End com_finder com_tags External Library Composer Change Installation Libraries |
Title |
|
Hi @LadySolveig, how can we help you to get this over the line?
Hi @LadySolveig, how can we help you to get this over the line?
I guess by fixing the conflict and make a PR against @LadySolveig repo :)
Labels |
Added:
Unit/System Tests
Language Change
Composer Dependency Changed
NPM Resource Changed
PR-6.0-dev
|
Category | Libraries Unit Tests Repository SQL Administration com_admin Postgresql com_users Language & Strings Modules JavaScript NPM Change Front End com_finder com_tags External Library Composer Change Installation | ⇒ | SQL Administration com_admin Postgresql Language & Strings Libraries |
Thank you @Bodge-IT for your interest 💚
After the very helpful hint from @dgrammatiko , I thought the PR would probably be better off in 6.0.
I have tested myself whether there is still a problem with sorting or filtering in the frontend. I have not been able to detect any more problems, but I have also included it in the testing instructions.
After the rebase I just waited for your upmerge to solve the remaining conflicts.
The note on the change in manual.joomla.org is still missing - I will deliver it soon and then gladly change the status to ready to review. 😊
I have tested this item ✅ successfully on 5b16e75
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44501.