PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
21 Nov 2024

Pull Request for Issue # .

Summary of Changes

This PR adds the js-grid-item-is-checked class and remove onClick in the HtmlHelper for Grid as it was originally prepared in the script.

target.querySelectorAll('.js-grid-item-is-checked').forEach((element) => element.addEventListener('click', applyIsChecked));

Testing Instructions

  • (optional) install sample data
  • go to articles list view
  • try out if you can mark single articles bei checkbox and by clicking on the row
  • try out if you can mark multiple articles
  • try out if you can select and deselect all articles
  • try if you can mark articles and use the batch processes

Install this PR
Do the same again.

Actual result BEFORE applying this Pull Request

All should work.

Expected result AFTER applying this Pull Request

All should work as before.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 21 Nov 2024
avatar LadySolveig LadySolveig - change - 21 Nov 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2024
Category Libraries
5b16e75 21 Nov 2024 avatar LadySolveig cs
avatar LadySolveig LadySolveig - change - 21 Nov 2024
Labels Added: PR-5.3-dev
avatar LadySolveig LadySolveig - change - 21 Nov 2024
The description was changed
avatar LadySolveig LadySolveig - edited - 21 Nov 2024
avatar Quy Quy - test_item - 21 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 21 Nov 2024

I have tested this item ✅ successfully on 5b16e75


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44501.

avatar dgrammatiko
dgrammatiko - comment - 22 Nov 2024

FWIW I had to revert this some time ago as it broke 3rd PD code: #40192
But would be cool to have CSP strict OOTB at some point

Add a Comment

Login with GitHub to post a comment