User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Add commands
composer run phpcscomposer run csfixerAdd excludes for cacheand logsdirectory to php-cs-fixer configuration as we have the same exlcudes for phpcs.
Improvement for our nice contributors.
Open a terminal (and step into the cloned joomla developement folder)
composer icomposer run phpcscomposer run csfixerPlease select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: joomla/Manual#337
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | External Library Composer Change |
No, absolutely not an expected result.
I have tried to replicate your issue but unfortunately I can't recreate it at the moment.
I have seen you run it directly on Windows.
Since I usually use Linux, I have now installed php 8.3 and composer directly on Windows.
But for me it runs without errors here too.
Is your IDE or your Git client possibly doing something with the line endings?
This pull request has been automatically rebased to 6.0-dev.
| Title |
|
||||||
Before applying the patch I ran composer i and got Nothing to install, update or remove. The composer run phpcs and composer run csfixer both failed as described.
I then applied the patch and ran composer i - that gave me:
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. It is recommended that you run
composer updateorcomposer update <package name>.
- Required package "joomla/application" is in the lock file as "3.0.1" but that does not satisfy your constraint "^3.0.2".
and about 30 lines like the latter.
composer run phpcs gave me a lot of deprecation warnings, then the block of tesets 2% at a time and then many many report lines finishing with
Script ./libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml . handling the phpcs event returned with error code 2
The composer run csfixer command retrned
./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff
PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.3.*.
Current PHP version: 8.4.7.
To ignore this requirement please setPHP_CS_FIXER_IGNORE_ENV.
If you use PHP version higher than supported, you may experience code modified in a wrong way.
Please report such cases at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer .
Script ./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff handling the csfixer event returned with error code 1
Perhaps the testing instructions need to be more specific?
@LadySolveig just looking through the features before beta1, did you see @ceford comments, is there anything else to be done before we try to get more testers?
Thank you
This pull request has been automatically rebased to 6.1-dev.
| Title |
|
||||||
Is this ready to test?
I fixed the problem I reported earlier about line endings. That was a git config issue at my end
I have successfully tested composer run phpcs
However testing csfixer I get the following message - I am running php 8.5
> ./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff
PHP needs to be a minimum version of PHP 7.4.0 and maximum version of PHP 8.3.*.
Current PHP version: 8.5.0.
To ignore this requirement please set `PHP_CS_FIXER_IGNORE_ENV`.
If you use PHP version higher than supported, you may experience code modified in a wrong way.
Please report such cases at https://github.com/PHP-CS-Fixer/PHP-CS-Fixer .
Script ./libraries/vendor/bin/php-cs-fixer fix -vvv --dry-run --diff handling the csfixer event returned with error code 1
It looks like the version of php-cs-fixer needs to be update in composer.json
ah the problem is that composer.json in this branch is out of date. Can you please update the branch
| Labels |
Added:
Feature
Composer Dependency Changed
PR-6.0-dev
PR-6.1-dev
|
||
Thanks @brianteeman branch updated.
@coolcat-creations is ready to test. Everything works fine for me on Linux, but tests on Mac and Windows are very welcome.
Can you please update the version of php-cs-fixer in the composer.json as it is currently locked to a version that doesnt support php 8.5
"friendsofphp/php-cs-fixer": "^3.88.0",
===>
"friendsofphp/php-cs-fixer": "^3.91.0",
assuming php-cs-fixer is updated then it tests correctly on php 8.5 and I can mark this PR as successfully tested
Works as expected thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-12-12 12:25:24 |
| Closed_By | ⇒ | HLeithner |
wow you merged it - without the required changes to make it work in php 8.5
Updating packages is unrelated to this pr, we already did this today in another pr, but seems to miss the dev dependencies for composer, will be done before next alpha.
without the uodate this or dioes not work in 8.5
is it expected to get this error at the end of running phpcs?
and this error at the end of running csfixer