User tests: Successful: Unsuccessful:
This pull request fixes a bug in the Bootstrap Caraousel implementation of Joomla! (PHP and ES/JS) that causes valid parameters to be removed from the JavaScript options object that is fed to the Carousel instance. It replaces #38930.
I (still) do not know if the Patch Tester extension will do the JavaScript re-build / pre-processing for you, and hope you know best what to do in this regard. In any case, I've attached not only a demo / test module but also the changed files.
All options set to false are filtered out, causing the carousel to fall back to its default values (not sliding).
Params that can have a false value are recognised and the carousel works as expected.
Documentation link for docs.joomla.org: https://docs.joomla.org/J4.x:Using_Bootstrap_Components_in_Joomla_4#Carousel (slide vs. ride)
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@Quy Please let me know if I have missed anything. Also, the problem with filtered parameters may not only exist in the carousel implementation, but in any other Bootstrap component where "false" is a valid option and array_filter is used in the corresponding helper method.
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change Libraries |
People can download a package created by Drone, or update to that package using a custom URL. Both can be found by following the "Details" link at the right side of the "Download" step in the CI checks at the bottom of this PR.
Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
The Pull Request have the Label
NPM Resource Changed
; hovering the Label giveThis Pull Request can't be tested by Patchtester
.