Feeling Lucky
Unit/System Tests
NPM Resource Changed
PR-5.3-dev
[#44440] - [5.3] Test Upmerge
- Closed
- 16 Nov 2024
- Medium
- Build: 5.3-dev
- Draft PR
- # 44440
- Diff
- heelc29:5.3/upmerge-2024-11-11
User tests: Successful: Unsuccessful:
test drone
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin SQL Postgresql com_content com_installer com_menus com_users Language & Strings Templates (admin) JavaScript Repository NPM Change |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.3-dev
|
||
heelc29
- comment
- 13 Nov 2024
We should not ‘hide’ direct changes in the library, nor the enhancement of the test in an upmerge.
That wasn't my intention either, so this is in draft state.
My target is to split this into 2-3 PRs:
- new tests for 5.2-dev
- fix new preprocess rule
- new tests for 5.3-dev
| Category | Administration com_admin SQL Postgresql com_content com_installer com_menus com_users Language & Strings Templates (admin) JavaScript Repository NPM Change | ⇒ | Administration com_media Modules JavaScript Repository NPM Change Libraries Unit Tests |
HLeithner
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-16 18:47:56 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Unit/System Tests
Removed: Language Change |
||
Thank you so much for your work on this topic @heelc29 !
Could you please open a new PR for 5.3 with the changes from your last two commits. We should not ‘hide’ direct changes in the library, nor the enhancement of the test in an upmerge.
We will make the upmerge with these change 4f2a09e for the time being to prevent the test from breaking. But I would be very happy about a new PR from you with these changes to make it transparent for everyone in the project.