I have no idea how to test this one. Could you give a hint?

With great difficulty! This line is triggered when there is an error in PostgresSql on calling the execute function.

Before the error message from postgres you'll see the following string: Database query failed (error # %s): %s (including the %s) after the patch is applied all you'll see is the postgres error message

Feel free to ping back on here if there are any issues testing!

i have no idea .....................how i test this one ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4444.

Information for this task is not complete.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4444.

define useless!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4444.

@test OK
Issue reproduced. applied fix, PR resolves issue.
Very easy to reproduce! Edit an article and add a non-existing Tag. You'll get an error message saying there was an error, but without placing the error number and text where it should be.
Applying fix results in the following with red background as it should :
Error
Save failed with the following error: SQL=INSERT INTO "j336_ucm_content" ("core_type_alias","core_title","core_alias","core_body","core_state","core_access","core_params","core_featured","core_metadata","core_created_user_id","core_created_time","core_modified_time","core_language","core_publish_up","core_publish_down","core_content_item_id","core_images","core_urls","core_hits","core_version","core_ordering","core_metakey","core_metadesc","core_catid","core_xreference","core_type_id") VALUES ('com_content.article','Quick Icons','quick-icons','

The Quick Icon plugin group is used to provide notification that updates to Joomla! or installed extensions are available and should be applied. These notifications display on your administrator control panel, which is the page you see when you first log in to your site administrator.

Default on:

Quick icon - Joomla! extensions updates notification Help.
Quick icon - Joomla! update notification Help

',1,1,'{"show_title":"","link_titles":"","show_tags":"","show_intro":"","info_block_position":"","show_category":"","link_category":"","show_parent_category":"","link_parent_category":"","show_author":"","link_author":"","show_create_date":"","show_modify_date":"","show_publish_date":"","show_item_navigation":"","show_icons":"","show_print_icon":"","show_email_icon":"","show_vote":"","show_hits":"","show_noauth":"","urls_position":"","alternative_readmore":"","article_layout":"","show_publishing_options":"","show_article_options":"","show_urls_images_backend":"","show_urls_images_frontend":""}',0,'{"robots":"","author":"","rights":"","xreference":""}',798,'2011-01-01 00:00:01','2014-10-18 20:39:01','*','2012-01-17 03:27:39','1970-01-01 00:00:00',69,'{"image_intro":"","float_intro":"","image_intro_alt":"","image_intro_caption":"","image_fulltext":"","float_fulltext":"","image_fulltext_alt":"","image_fulltext_caption":""}','{"urla":false,"urlatext":"","targeta":"","urlb":false,"urlbtext":"","targetb":"","urlc":false,"urlctext":"","targetc":""}',0,3,0,'','',25,'',1) RETURNING core_content_id

@wilsonge I don't think this change should be made this way but rather use $this->errorMsg = JText::sprintf('JLIB_DATABASE_QUERY_FAILED', pg_last_error($this->connection), $query); That way we use the language string consistently.

But that is not compatible with the way we set the variable in mysql (see https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/driver/mysqli.php#L585) which i consider the 'standard' on which we fix postgres and mssql to

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4444.

Moving to RTC as we have 2 successful tests.

Looks good from code review too.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4444.