[#44342] - Update debug.es6.js SanitizHTML DOM Text Interpretd as HTML
- Fixed in Code Base
- 7 Nov 2024
- Medium
- Build: 5.2-dev
- # 44342
- Diff
- Shivam7-1:patch-3
User tests: Successful: Unsuccessful:
Summary of Changes
In This PR Joomla.sanitizeHtml to sanitize all HTML content rendered within the application. This change improves security by preventing XSS (Cross-Site Scripting) vulnerabilities and ensures that user-generated or external HTML is safe. All relevant components have been updated for consistent sanitization, enhancing overall application integrity.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
Hii @dgrammatiko @HLeithner Thanks For Suggestions
Could Anyone From Team Please Review This PR
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44342.
Hii @dgrammatiko @HLeithner this PR is ready for review.
Could you please take a look when you have time?
Let me know if you have any questions or suggestions.
Thanks!
How this can actually being exploited within the core? Can you provide some testing instructions how we can reproduce the issue you are trying to fix?
Pretty sure it's a good idea to sanitize it, we can't guarantee that the server send us valid and proper data since it's based on user input (if I read the code correctly it returns com_finder data).
@Shivam7-1 we need 2 tests to merge this, if someone came up and test it and mark it as tested on https://issues.joomla.org we can merge it.
I have tested this item ✅ successfully on 284ee8b
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44342.
I have tested this item ✅ successfully on 284ee8b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44342.
| Labels |
Added:
NPM Resource Changed
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-07 13:29:39 |
| Closed_By | ⇒ | SniperSister |
thanks @Shivam7-1
Hii @dgrammatiko @HLeithner Thanks For Suggestions
Could You Please Review This PR
Thanks