Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#44321] - [6.0] Remove leftover reCaptcha files

Feature NPM Resource Changed b/c break PR-6.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
20 Oct 2024

Summary of Changes

Remove leftover reCaptcha files, forgoten in #41530

Testing Instructions

Code review.

Or build the release packge, and check for /media/plg_captcha_recaptcha/ and /media/plg_captcha_recaptcha_invisible/. These folder should not exists.

Actual result BEFORE applying this Pull Request

recaptcha files in release packge

Expected result AFTER applying this Pull Request

no recaptcha files in release packge

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: joomla/Manual#182
  • No documentation changes for manual.joomla.org needed
avatar Fedik Fedik - open - 20 Oct 2024
avatar Fedik Fedik - change - 20 Oct 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Oct 2024
Category ⇒ JavaScript Repository NPM Change
avatar Fedik Fedik - change - 20 Oct 2024
The description was changed
avatar Fedik Fedik - edited - 20 Oct 2024
avatar Fedik
Fedik - comment - 24 Nov 2024

@Hackwar where is b/c break?

avatar Hackwar
Hackwar - comment - 24 Nov 2024

I just added the label as a technicality because we are removing files which people might still be using, but since it is against 6.0 anyway, it shouldn't really matter. I mean, in case someone wants a list of b/c breaks, now they can filter by that.

2c91f60 24 Nov 2024 avatar Fedik cs
avatar Fedik Fedik - change - 24 Nov 2024
Labels Added: Feature NPM Resource Changed b/c break PR-6.0-dev
avatar Fedik
Fedik - comment - 24 Nov 2024

Okay

I just added the label as a technicality because we are removing files which people might still be using

This does not removing files on update, only form release packge, which should be done in #41530 but I forgot.
The files will stay on User side if they in use.

avatar Quy Quy - test_item - 25 Nov 2024 - Tested successfully
avatar Quy
Quy - comment - 25 Nov 2024

I have tested this item ✅ successfully on 2c91f60

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.

Add a Comment

Login with GitHub to post a comment