[#44321] - [6.0] Remove leftover reCaptcha files
- Fixed in Code Base
- 12 Feb 2025
- Medium
- Build: 6.0-dev
- # 44321
- Diff
- Fedik:captcha-remove-js
User tests: Successful: Unsuccessful:
Summary of Changes
Remove leftover reCaptcha files, forgoten in #41530
Testing Instructions
Code review.
Or build the release packge, and check for /media/plg_captcha_recaptcha/ and /media/plg_captcha_recaptcha_invisible/. These folder should not exists.
Actual result BEFORE applying this Pull Request
recaptcha files in release packge
Expected result AFTER applying this Pull Request
no recaptcha files in release packge
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#182
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I just added the label as a technicality because we are removing files which people might still be using, but since it is against 6.0 anyway, it shouldn't really matter. I mean, in case someone wants a list of b/c breaks, now they can filter by that.
| Labels |
Added:
Feature
NPM Resource Changed
b/c break
PR-6.0-dev
|
||
I have tested this item ✅ successfully on 2c91f60
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.
I have tested this item ✅ successfully on 5c18128
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44321.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2025-02-12 18:55:29 |
| Closed_By | ⇒ | Bodge-IT |
If the files shall not be deleted on update, it needs to add them to the list of exceptions in the build/deleted_file_check.php script.
I will make a follow-up PR for that today or tomorrow.
@Hackwar where is b/c break?