Unit/System Tests PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar rdeutz
rdeutz
18 Oct 2024

Summary of Changes

Clean up the data in a different way.

avatar rdeutz rdeutz - open - 18 Oct 2024
avatar rdeutz rdeutz - change - 18 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2024
Category JavaScript Unit Tests
avatar rdeutz rdeutz - change - 18 Oct 2024
Title
[5.2] Fix Postgreas Problem in out testing
[5.2] Fix Postgreas Problem in our testing
avatar rdeutz rdeutz - edited - 18 Oct 2024
avatar rdeutz rdeutz - change - 18 Oct 2024
Title
[5.2] Fix Postgreas Problem in our testing
[5.2] Fix Postgres Problem in our testing
avatar rdeutz rdeutz - edited - 18 Oct 2024
avatar rdeutz rdeutz - change - 18 Oct 2024
Labels Added: Unit/System Tests PR-5.2-dev
avatar muhme
muhme - comment - 18 Oct 2024

From my point of view, it would be more beneficial to perform the cleanup in beforeEach rather than in afterEach. This prevents tests from failing after they are interrupted and avoids requiring the installation step. This change should be applied consistently across all tests, either by cleaning up all test-created database objects or using transactions. I like to discuss this further with @laoneo and @alikon.

Regarding the failing System Tests with the error duplicate key value violates unique constraint "_users_pkey" with PostgreSQL, from my point of view it is related to cleanupDB() is not completed before the next test run creates a new user and needs to be fixed on chaining and I'am working on resolving it.

avatar rdeutz
rdeutz - comment - 18 Oct 2024

From my point of view, it would be more beneficial to perform the cleanup in beforeEach rather than in afterEach. This prevents tests from failing after they are interrupted and avoids requiring the installation step. This change should be applied consistently across all tests, either by cleaning up all test-created database objects or using transactions. I like to discuss this further with @laoneo and @alikon.

Makes sense

Regarding the failing System Tests with the error duplicate key value violates unique constraint "_users_pkey" with PostgreSQL, from my point of view it is related to cleanupDB() is not completed before the next test run creates a new user and needs to be fixed on chaining and I'am working on resolving it.

The cleanupDB is a good idea, haven't looked at the test for a longer time and didn't noticed this. But as far as I understand it it runs only after a block and not after a single test. So my guess is that this will not help.

Add a Comment

Login with GitHub to post a comment