Thanks.
Please change the target to 6.0-dev, because we still need to fix that issue

• #44294

@Fedik why? That is for 5.2 and this PR is for 5.2. Why would I rebase it to 6

To fix the linked issue we still need to serve these js files.
If we remove it now Users will stay with broken js code released with 5.2.0

This just removes those files from NEW installs of 5.2 which dont have the plugin and should have been done with #41530

The problem of the missing files was because they were removed on update

That is a different issue and needs a different PR to this

This just removes those files from NEW installs of 5.2 which dont have the plugin and should have been done with #41530

The problem of the missing files was because they were removed on update

joomla-cms/administrator/components/com_admin/script.php

Lines 1247 to 1249 in 59b1341

	'/media/plg_captcha_recaptcha_invisible/js/recaptcha-es5.js',
	'/media/plg_captcha_recaptcha_invisible/js/recaptcha-es5.min.js',
	'/media/plg_captcha_recaptcha_invisible/js/recaptcha-es5.min.js.gz',

That is a different issue and needs a different PR to this

If they shall not be removed on update, they need to be removed from script.php, and in addition it needs to add them to the list of exceptions in the deleted files check like I had done it with my PR #42936 for other files.

@brianteeman you refering to es5 files. I am talking about regular.
We do not delete them on update (j4 to j5), because we do not uninstall invisible reCaptcha.

The issue that this files should not be released for update/install packges, but I forgot to delete them in my PR.

This just removes those files from NEW installs of 5.2

And for update package

And for update package

They are not needed in the update package as they are already installed. The problem was that the existing installed files were removed by script.php on update which is the error

To be clear there are multiple errors

1. The pr to remove captcha was incomplete and this PR addresses that
2. The files were removed on update - they should not have been

2. The files were removed on update - they should not have been

@brianteeman As I said: If they shall not be removed on update it needs to do what I had done it with my PR #42936 for other files.

The pr to remove captcha was incomplete and this PR addresses that

yes, but we cannot remove them anymore, untill 6.0. Because we still need to release the fix for #44294

The files were removed on update - they should not have been

They were NOT removed, becase we do not uninstall the invisible captcha, only older recaptcha v2 was uninstalled.
That was intended.

@richard67 made everything right. It just me forgot to remove them in original PR, to prevent further release of these files.

no point in me continuing here as you are not listening or reading

hm? Your PR is fine, it just need to be to 6.0

As I said you are not reading. this is needed for 5.2 but I have better things to do with my time than to repeat the obvious

Look, we remove build/media_source/plg_captcha_recaptcha_invisible/js/recaptcha.es6.js now, in 5.2.
Question: how do we release the fix for #44294 then?

@brianteeman do you reopen the PR for 6.0 or should I copy?