PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
16 Oct 2024

Pull Request for Issue #44270.

Summary of Changes

PluginHelper::getPlugin() currently returns either an (empty) array of objects or a single object. This is the first step towards cleaning that code up by splitting the code up into a method to retrieve a single plugin (getPlugin()) and an array of plugins (getPlugins()).

Testing Instructions

Codereview.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 16 Oct 2024
avatar Hackwar Hackwar - change - 16 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2024
Category Administration com_finder com_media com_users Front End com_contact com_content Libraries
avatar Hackwar Hackwar - change - 16 Oct 2024
Labels Added: PR-5.3-dev
avatar brbrbr
brbrbr - comment - 16 Oct 2024

This pull request does not solve the issue of:

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

The sef plugin must be enabled, always.

avatar fgsw
fgsw - comment - 24 Oct 2024

This pull request does not solve the issue of:

Warning: Attempt to read property "params" on array in [ROOT]libraries/src/Component/Router/Rules/MenuRules.php

@brbrbr Test #44283

avatar laoneo
laoneo - comment - 18 Nov 2024

When I see this code, then the plugin should either be booted or the PluginsModel should be used instead of introducing another static function with deprecated global static Factory calls.

Add a Comment

Login with GitHub to post a comment