[#44276] - [5.4] Sef: Fixed protocols regex to comply with RFC 3986.
- Pending
- Medium
- Build: 5.2-dev
- # 44276
- Diff
- AkameOuO:5.2-fix-protocol-regex
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
According to https://datatracker.ietf.org/doc/html/rfc3986#section-3.1 , protocol (or scheme) should consist of a sequence of characters beginning with a letter and followed by any combination of letters, digits, plus ("+"), period ("."), or hyphen ("-").
Testing Instructions
URIs with custom protocols containing +, . should not be prepended with base.
And URIs with custom protocols start with number or - should be prepended with base.
Actual result BEFORE applying this Pull Request
Custom protocols like web+tea: will be prepended with base.
Custom protocols like -http: or 1http will not be prepended with base.
Expected result AFTER applying this Pull Request
Custom protocols like web+tea: will not be prepended with base.
Custom protocols like -http: or 1http will be prepended with base.
Link to documentations
Please select:
-
No documentation changes for docs.joomla.org needed
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
- libraries/src/Form/Rule/UrlRule.php
This file uses libraries/vendor/joomla/uri/src/UriHelper.php, which relies on parse_url(). I've tested that parse_url() allows URLs with non-alphabetic leading characters in the scheme. I'm uncertain whether this file also needs modification, given that it's related to PHP's built-in function behavior.
- administrator/components/com_menus/src/Controller/ItemController.php
This seems ok. It appears to only allow a predefined list of URL schemes. And listed schemes won't meet this problem.
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
This pull request has been automatically rebased to 5.4-dev.
richard67
- | Title |
|
||||||
| Labels |
Added:
bug
PR-5.4-dev
|
||
so its really just a case of confirming that the regex satisfies the RFC spec
Scheme names consist of a sequence of characters beginning with a
letter and followed by any combination of letters, digits, plus
("+"), period ("."), or hyphen ("-").
My regex might be wrong but I think this regex is not correct due to the . towards the end
I believe this regex is correct
^([A-Za-z][A-Za-z0-9+.-]*):
Do we also need to fix the checks in