RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Oct 2024

Resolve todo as we only support php8 now.

This should probably have been done when I did #41885

Original PR where this check was added #28694

Testing Instructions

code review

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar brianteeman brianteeman - open - 16 Oct 2024
avatar brianteeman brianteeman - change - 16 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Oct 2024
Category Libraries
avatar brianteeman brianteeman - change - 16 Oct 2024
Labels Added: PR-5.3-dev
avatar Quy Quy - test_item - 16 Oct 2024 - Tested successfully
avatar Quy
Quy - comment - 16 Oct 2024

I have tested this item ✅ successfully on aca08a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44275.

avatar brianteeman brianteeman - change - 16 Oct 2024
The description was changed
avatar brianteeman brianteeman - edited - 16 Oct 2024
avatar alikon alikon - test_item - 17 Oct 2024 - Tested successfully
avatar alikon
alikon - comment - 17 Oct 2024

I have tested this item ✅ successfully on aca08a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44275.

avatar alikon alikon - change - 17 Oct 2024
Status Pending Ready to Commit
avatar alikon
alikon - comment - 17 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44275.

avatar rdeutz rdeutz - change - 17 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-17 07:12:11
Closed_By rdeutz
Labels Added: RTC
avatar rdeutz rdeutz - close - 17 Oct 2024
avatar rdeutz rdeutz - merge - 17 Oct 2024
avatar rdeutz
rdeutz - comment - 17 Oct 2024

Thanks

avatar brianteeman
brianteeman - comment - 17 Oct 2024

thx

Add a Comment

Login with GitHub to post a comment