[#44274] - [5.3] Remove TODO joomla-alert.scss
- Fixed in Code Base
- 18 Oct 2024
- Medium
- Build: 5.3-dev
- # 44274
- Diff
- brianteeman:state_warning_todo
User tests: Successful: Unsuccessful:
While reviewing existing @todo I came across these two.
The first one is not needed as the variable has the same value The second one makes no sense
@coolcat-creations these were your todo comments from #42986 - have I missed something or can they simply be removed
Testing Instructions
code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.3-dev
|
||
| Category | Repository NPM Change | ⇒ | Repository NPM Change Libraries |
| Category | Repository NPM Change Libraries | ⇒ | Repository NPM Change |
Thanks for confirming. You are not alone of the 300+ todo many of them make no sense at all and have been there for a very very long time
@brianteeman I wanted to test by download prepbuild package as it has the "NPM Resource Changed" label but could not find build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss in the package.
Thanks for information that the pull request can't get a test by prebuilt package.
I agree that todos are often not useful, I will put this on the maintainers agenda, I think a todo should contain a version we have to work on the todo, a description and maybe a reason.
understandable after months/years, if we force people to write more about the todo changes are goodl that they know why
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-18 08:43:44 |
| Closed_By | ⇒ | rdeutz |
Thanks
understandable after months/years, if we force people to write more about the todo changes are goodl that they know why
hence my comment on your todo yesterday ;)
Sorry I don't understand these TODOS anymore ;(
next time I need to write why or so... I think it can be removed.