Unit/System Tests PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
14 Oct 2024

Summary of Changes

add tests for site router (sef) and should cover:

Testing Instructions

drone
code review

Actual result BEFORE applying this Pull Request

no sef tests

Expected result AFTER applying this Pull Request

test coverage

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar heelc29 heelc29 - open - 14 Oct 2024
avatar heelc29 heelc29 - change - 14 Oct 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2024
Category JavaScript Unit Tests
avatar heelc29 heelc29 - change - 14 Oct 2024
Labels Added: Unit/System Tests PR-5.2-dev
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2024
Category JavaScript Unit Tests Repository JavaScript Unit Tests
avatar laoneo
laoneo - comment - 15 Oct 2024

You can rename the htaccess.txt in beforeEach to .htaccess and in afterEach back to .txt.

avatar heelc29
heelc29 - comment - 15 Oct 2024

You can rename the htaccess.txt in beforeEach to .htaccess and in afterEach back to .txt.

At the moment I'm struggle a bit with copying/renaming the file.

avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2024
Category JavaScript Unit Tests Repository JavaScript Unit Tests
avatar joomla-cms-bot joomla-cms-bot - change - 15 Oct 2024
Category JavaScript Unit Tests Unit Tests Repository JavaScript
avatar heelc29
heelc29 - comment - 15 Oct 2024

It looks like mod_rewrite is not enabled in docker image.

avatar heelc29
heelc29 - comment - 28 Oct 2024

Ready for review

avatar laoneo laoneo - change - 30 Oct 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-30 07:13:34
Closed_By laoneo
avatar laoneo laoneo - close - 30 Oct 2024
avatar laoneo laoneo - merge - 30 Oct 2024
avatar laoneo
laoneo - comment - 30 Oct 2024

@heelc29 I contacted you on matermost, if you have time, would be great if you can respond.

Anyway, good work!

Add a Comment

Login with GitHub to post a comment