[#44206] - [5.2] Fix contact state filter for administrator
- Pending
- Medium
- Build: 4.4-dev
- # 44206
- Diff
- artur-stepien:patch-2
User tests: Successful: Unsuccessful:
There was a bug in state filtering of CategoryModel that lead to administrators seeing trashed items in the front-end.
Summary of Changes
Changed the state filter to filter the contact items.
Testing Instructions
- Create 2 contacts: contact A and contact B to Uncategorized
- Move contact B to Trash
- Create a front-end menu item of type List Contacts in a Category and select Uncategorized
- Visit front-end logged in as a Super Administrator and click the menu item created in previous step
Actual result BEFORE applying this Pull Request
Both contacts visible
Expected result AFTER applying this Pull Request
Only contact A should be visible
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
It is not a bug it is the intended behaviour
How on earth showing trashed items only in the Contact component front-end is an intended behaviour?
How on earth showing trashed items only in the Contact component front-end is an intended behaviour?
The same with articles. Otherwise the admin is not able to untrash/publish etc a contact when managing in the front end. That is why the state of the contact is displayed. (Perhaps you have a template which is overriding this view and not displaying the status
How on earth showing trashed items only in the Contact component front-end is an intended behaviour?
The same with articles. Otherwise the admin is not able to untrash/publish etc a contact when managing in the front end. That is why the state of the contact is displayed. (Perhaps you have a template which is overriding this view and not displaying the status
It doesn't work like this in the Content component. And I just checked that to be sure for both blog and default layouts. Contact is the only place where I found such behaviour.
Even if the intended behaviour is not to display these contacts the PR is obvioulsy not complete as you would surely need to update this as well.
joomla-cms/components/com_contact/tmpl/category/default_items.php
Lines 126 to 153 in 36729f6
I think there are some bits missing, for example if the category is unpublished it shouldn't be shown.
Maybe check how it's done in com_content and replicate this to com_contact?
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
I think there are some bits missing, for example if the category is unpublished it shouldn't be shown. Maybe check how it's done in com_content and replicate this to com_contact?
Unpublished items for administrators are shown in most of the core components. But only Contact had Trashed items visible too. The behaviour is copied from com_content in this PR. Only missing bit are changes in the view layout to not check for trashed state but I have no time this week for this.
There has to be another PR for category state filtering but the problem is 4.4 does not have subcategories filtering. Should I create a separate PR adding category state filtering for 4.4 and 5.1?