[#44205] - [5.2] SEF: Don't remove trailingslash on hp in a subdir
- Fixed in Code Base
- 8 Oct 2024
- Medium
- Build: 5.2-dev
- # 44205
- Diff
- Hackwar:5.2-sef-slash-fix
User tests: Successful: Unsuccessful:
Summary of Changes
When running an installation in a subdirectory with strict routing enabled, the last slash is removed and a redirect is executed, breaking for example the login. This PR fixes that. A big thanks goes to @LadySolveig, who reported this.
Testing Instructions
Install a Joomla 5.2.0 or use an updated site in a subdirectory. In case of an updated site, enable strict routing in the SEF system plugin. Make sure that the site is using URL rewriting. Login on the frontend.
Actual result BEFORE applying this Pull Request
Login doesn't work.
Expected result AFTER applying this Pull Request
Login works.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I'm sorry, yes, you have to enable URL rewriting as well. I'm going to update the test instructions.
I have tested this item ✅ successfully on 0ccbdfe
I was able to reproduce the issue (5.2.0-rc3 in a subfolder with URL Rewriting enabled and a standard .htaccess file present) and have verified that this PR fixes the issue.
I've also checked that with a "normal" installation not in a subfolder and URL Rewriting enabled everything works as well as before.
Finally I've checked on both installations that without URL rewriting everything works as well as before.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44205.
| Labels |
Added:
Release Blocker
bug
PR-5.2-dev
|
||
I have tested this item ✅ successfully on 61e5256
Without the patch, the frontend login via the login module does not work. I was able to test this successfully with the patch.
As a note, the login also works without a patch via https://yoururl.tld/joomla-in-subfolder/component/users/login
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44205.
Couldn't reproduce the issue on my local test installation (Laragon). Login works under the conditions given with or without the patch.
Couldn't reproduce the issue on my local test installation (Laragon). Login works under the conditions given with or without the patch.
It needs to use the module, not a menu item for the login, and the Joomla has to be in a subfolder, and URL rewriting has to be switched on and a standard .htaccess has to be in the subfolder.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44205.
@richard67 I used a menu item for the login. Anyway, there a two successful tests, and the PR is RTC.
@richard67 I used a menu item for the login. Anyway, there a two successful tests, and the PR is RTC.
module in sidebar is the trick
Thank you all 💚
I have tested this item ✅ successfully on 61e5256
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44205.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-08 10:07:06 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
RTC
|
||
Thanks for the fix @Hackwar and for the tests @richard67 @tecpromotion and for the find + test @LadySolveig
Hmm, I could only reproduce the issue when switching on "Use URL Rewriting" in Global Config and having a standard .htaccess file in addition to what's described.
I made a new installation of 5.2.0-rc3 in a subfolder. The parent folder which is the webserver root is empty except of that subfolder. Then I have tried frontend login and it worked. Then I've switched on "Use URL Rewriting" in Global Config and copied htaccess.txt to .htaccess. After that I could reproduce the issue.
Then I have switched off "Use URL Rewriting" in Global Config but kept the .htaccess file, and then frontend login worked again.
@Hackwar Can you confirm? If so, could you update testing insctructions?