[#44199] - [4.4] Fix the actions menu in the admin isn't working on mobile
- Fixed in Code Base
- 7 Oct 2024
- Medium
- Build: 4.4-dev
- # 44199
- Diff
- AkameOuO:fix-44198
User tests: Successful: Unsuccessful:
Pull Request for Issue #44198 .
Summary of Changes
Fix the actions menu in the admin isn't working on mobile
Testing Instructions
Select one or more articles / users from the list. Then click in the top right corner to open the menu and click on 'Actions'.
Actual result BEFORE applying this Pull Request
The whole menu is closed.
Expected result AFTER applying this Pull Request
Open the submenu to give you a choice
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
It seems that the issue at hand is introduced with my PR for issue #43891, solving overlapping dropdowns.
My fix was closing all data-bs-toggle="collapse" when opening a data-bs-toggle="dropdown".
This fix seems to introduce an issue on small screens where the Actions dropdown is revealed after clicking the reveal button top right. Since the latter has data-bs-toggle="collapse" and the Actions has data-bs-toggle="dropdown" it will be closed when trying to open the dropdown.
Adding the check as proposed in this PR solves that issue. Good catch @AkameOuO
I have tested this item ✅ successfully on 43c6243
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44199.
I have tested this item ✅ successfully on 43c6243
Tested successfully on 4.4.8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44199.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
bug
PR-4.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44199.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-07 10:34:49 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
RTC
|
||
Thank you
@hans2103 Could you have a look on this PR here and the corresponding issue #44198 ? It seems to me that it was introduced with your PR #43891 , or at least this PR modifies what you had introduced with your PR.