[#44162] - [5.3] Deprecate AbstractView::get()
- Fixed in Code Base
- 5 Oct 2024
- Medium
- Build: 5.3-dev
- # 44162
- Diff
- Hackwar:5.3-view-get
User tests: Successful: Unsuccessful:
Summary of Changes
In a time far far away, someone thought it might be a good idea to introduce an indirection in the view to get the data from the model by adding AbstractView::get(), which retrieves the model and then runs get<Parameter>() on the model. This removes any chance of typehinting, etc. and makes everything unnecessarily complex, so we are deprecating this method with this PR.
The new way hence forth shall be for example:
public function display($tpl = null)
{
$model = $this->getModel();
$this->items = $model->getItems();
parent::display($tpl);
}
Testing Instructions
Codereview
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org: joomla/Manual#318
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
The PR for manual.joomla.org has been created and linked. The question is how to get all the occurences of this in docs.joomla.org removed? Since there are plans on changing docs.joomla.org, should we change it there now?
| Labels |
Added:
PR-5.3-dev
|
||
I added a deprecation trigger to the method.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-05 11:23:07 |
| Closed_By | ⇒ | laoneo |
Thanks!
Can you make here the manual entry as well?