[#44161] - [5.3] Customfields: Also look at context when checking uniqueness
- Fixed in Code Base
- 10 Oct 2024
- Medium
- Build: 5.3-dev
- # 44161
- Diff
- Hackwar:5.3-customfields-alias
User tests: Successful: Unsuccessful:
Pull Request for Issue #44154 .
Summary of Changes
Customfields should only be uniquely named per context, so you should be able to have a field test in both articles and users. So far this is prohibited and you can only name a field uniquely system wide. This PR should fix that.
Testing Instructions
Create a customfield with name test in articles and in users.
Actual result BEFORE applying this Pull Request
Creating the second field is denied.
Expected result AFTER applying this Pull Request
Both fields can be saved.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
I have tested this item ✅ successfully on 58ccfe1
Test same Field name on
- Content
- Articles
- Category
- Contact
- Contact
- Category
- Users
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44161.
I have tested this item ✅ successfully on 58ccfe1
I tried to create a custom field in Content and Users with the same name.
It was not possible until I applied the patch.
Later on I used both the user field and the content field and each one kept its value and appeared in the correct place.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44161.
@Hackwar can you also change the text in the mentioned string from @brianteeman?
| Labels |
Added:
Updates Requested
bug
PR-5.3-dev
|
||
| Category | Administration com_fields | ⇒ | Administration com_fields Language & Strings |
Done
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44161.
| Labels |
Added:
RTC
Language Change
Removed: Updates Requested |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-10 12:42:44 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
Documentation Required
|
||
Thanks!
The error message needs to be updated as currently it says
COM_FIELDS_ERROR_UNIQUE_NAME="Another Field has the same name (remember it may be a trashed item or it may be already present as a custom field in another extension)."
It can now be simplified and made more consistent with other strings eg
COM_FIELDS_ERROR_UNIQUE_NAME="Another Field has the same name (remember it may be a trashed item)."