? Success

User tests: Successful: Unsuccessful:

avatar alexvanniel
alexvanniel
1 Oct 2014

This fix will solve the problem of duplicate data when the modal of the repeatable element is closed. Currently when you press cancel and reopen the modal view of the repeatble element, the data that was already present is now duplicated. The probblem was found and fixed by JohhnyPixel: http://joomla.stackexchange.com/users/427/jonnypixel
The problem was reported and fixed here: http://joomla.stackexchange.com/a/903

avatar alexvanniel alexvanniel - open - 1 Oct 2014
avatar jissues-bot jissues-bot - change - 1 Oct 2014
Labels Added: ?
avatar alexvanniel alexvanniel - change - 1 Oct 2014
Title
Update repeatable-uncompressed.js
Fix duplicating existing data in repeatble modal window (uncompressed version of the script)
avatar alexvanniel
alexvanniel - comment - 2 Oct 2014

I did an upgrade to 3.3.6 just now. It did not overwrite my local changes so I guess there were no changes to the repeatable formfield javascript. I am not running a bleeding edge or beta version if that is what you mean though. I saw that a PR has been merged to 3.4beta, I am not running that though.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4416.

avatar brianteeman brianteeman - change - 2 Oct 2014
Title
Fix duplicating existing data in repeatble modal window (uncompressed version of the script)
Update repeatable-uncompressed.js
avatar brianteeman brianteeman - change - 2 Oct 2014
Category JavaScript
avatar wilsonge
wilsonge - comment - 2 Oct 2014

Hi,
Yes this doesn't actually fix the issue - we have had this fix before - but I think there were issues with the add buttons off the top of my head (sorry not in a place where i can test again right now)

We've completely rewritten the form field in Joomla 3.4 so I think you'll probably just going to have to wait until then. Because that's going to be the next release anyhow - I think we're looking to have first alpha's in the next week or two if nothing more goes wrong :)

avatar alexvanniel
alexvanniel - comment - 2 Oct 2014

Hi Wilsonge,
It seemed to work but I must admi tI did not test it thoroughly since I did not have that much time to test and play with it. For now I have moved away from the repeatable formfield, mostly because of the problems with fields that are of type editor for instance and the problems with responsiveness of the modal. But also because I could not change fields on the fly like I sometimes do with setFieldAttribute.
Shall I just close this PR or do I need to do something else to make sure this PR is ignored?

avatar wilsonge
wilsonge - comment - 2 Oct 2014

Yeah just close the PR's. I think the new layouts should help a lot. If you have time just try replacing the JS file and the files in libraries/joomla/form/fields/repeatable.php with the ones in the 3.4-dev branch and see if that helps fix your issues

At the end of the day having these things in a modal is going to cause issues with responsiveness and the fields are aligned in rows to group them together. Which is always gonna have repsonsive issues when you have like 3/4 fields in one line on a mobile! But it's a constant work of improvement :)

avatar alexvanniel alexvanniel - close - 2 Oct 2014
avatar alexvanniel
alexvanniel - comment - 2 Oct 2014

As soon as I have some extra time I will take a look. Would however, rendering the controls in the main edit page instead of in a modal not be an easier way of doing things? It would at the very least open the door to repsonsivenes. At the end of the day modal windows are always going to be a problem when the content in a modal is bigger than the screen it is presented on, not just mobile devices. I tried to insert about 6 fields on one line in the repeatable formfield and I had ... interesting results ;-)
Make no mistake, I think that having a repeatable formfield in Joomla is great! As soon as I saw it mentioned somewhere I wondered why on earth nobody had thought about it before :)

avatar alexvanniel alexvanniel - close - 2 Oct 2014
avatar alexvanniel alexvanniel - change - 2 Oct 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-10-02 09:29:36
avatar alexvanniel alexvanniel - head_ref_deleted - 2 Oct 2014

Add a Comment

Login with GitHub to post a comment