PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
29 Sep 2024

Pull Request for Issue # .

Summary of Changes

When the option Title Only (lists) is selected in mod_articles, the option Trigger Plugin Events is visible. This is the wrong behavior and this PR fixes the issue.

Testing Instructions

See if the option Trigger Plugin Events is hidden when Title Only (lists) is selected.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar RickR2H RickR2H - open - 29 Sep 2024
avatar RickR2H RickR2H - change - 29 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2024
Category Modules Front End
avatar Kostelano
Kostelano - comment - 29 Sep 2024

Is there a reason why this option is placed sort of in the middle of the appearance settings? I think it would look much more appropriate at the very bottom, rather than before the introductory text and below the tag settings.

avatar RickR2H
RickR2H - comment - 29 Sep 2024

@Kostelano In the current mod_articles_news the option is right after the show title option. So my approach was to keep is somewhere in the same position, after the header and top information. If it's really user unfriendly in a new PR the position of this option could be moved. With these kind of options it's mostly a matter of opinion as there is no direct guideline how options should be ordered for the best UI/UX.

avatar Kostelano Kostelano - test_item - 29 Sep 2024 - Tested successfully
avatar Kostelano
Kostelano - comment - 29 Sep 2024

I have tested this item ✅ successfully on 9a6af1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44155.

avatar Hackwar Hackwar - change - 29 Sep 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-29 09:13:50
Closed_By Hackwar
Labels Added: PR-5.2-dev
avatar Hackwar Hackwar - close - 29 Sep 2024
avatar Hackwar Hackwar - merge - 29 Sep 2024
avatar Hackwar
Hackwar - comment - 29 Sep 2024

Since this is a simple fix, I'm okay with one test. Thank you @Kostelano for testing and thank you @RickR2H for your contribution.

Add a Comment

Login with GitHub to post a comment