[#44153] - [5.2] Add active class to active item in mod_ articles
- Fixed in Code Base
- 4 Oct 2024
- Medium
- Build: 5.2-dev
- # 44153
- Diff
- RickR2H:active-state
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The new mod_articles module has no active class for the active item like there was in mod_articles_category. This PR adds this functionality.
Testing Instructions
- Create a list of articles with the module active on all pages.
- Open the inspector in the browser.
- With the Title Only (lists) option selected, see if the link to the current article has an active class.
Actual result BEFORE applying this Pull Request
No active class
Expected result AFTER applying this Pull Request
Has an active class
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Repository Administration com_admin SQL |
richard67
- | Labels |
Added:
PR-5.2-dev
|
||
| Build | 4.4-dev | ⇒ | 5.2-dev |
| Category | Unit Tests Repository Administration com_admin SQL | ⇒ | Modules Front End |
tecpromotion
- | Title |
|
||||||
Agreed that with :has selector the article element now can be selected. Is a coverage of 91,66% acceptable to remove the active class on the article element? If so then I'll remove the outer class.
@brianteeman please test the active link for the article list.
I have tested this item ✅ successfully on b2494eb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44153.
I have tested this item ✅ successfully on b2494eb
I have followed test instructions.
Active class appeared in title when the patch was applied, even with Title Only.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44153.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44153.
| Labels |
Added:
RTC
|
||
Hackwar
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-10-04 17:45:58 |
| Closed_By | ⇒ | Hackwar |
There is an active class already. Maybe its in the wrong place? I doubt we need two
joomla-cms/modules/mod_articles/tmpl/default_items.php
Line 37 in 20cfbbf