[#44122] - [5.2] [Guided Tours] Fix validation of the tour relative URL
- Pending
- Medium
- Build: 5.2-dev
- # 44122
- Diff
- obuisard:guided-tours-toururlvalidation
User tests: Successful: Unsuccessful:
Pull Request for Issue #40020.
Summary of Changes
The tour's relative URL path is not validated and can lead to 404 errors once run.
Testing Instructions
Go to System -> Manage section -> Guided Tours.
Enter one of the core tours.
Change the path of the relative URL.
Try different combinations, for instance:
/administrator/index.php
administrator/index.php2
administrator/tada/index.php
https://_[your host here]_/administrator/index.php
administrator/index.php?option=com_banners&view=bannersqq
Actual result BEFORE applying this Pull Request
The URL is saved no matter what.
Expected result AFTER applying this Pull Request
There is an error message if the URL is not correct or does not lead to any valid page.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
Language Change
PR-5.2-dev
Guided Tours
|
||
| Title |
|
||||||
screenshot of error
I have tested this item 🔴 unsuccessfully on 0c5c222Go to System -> Manage section -> Guided Tours Steps to recreate error:
Edit "How to create banners?" tour Changed URL from administrator/index.php?option=com_banners&view=banners to administrator/index.php?option=com_banners&view=bannersqq Save and Close Run tour An error has occurred. 404 View not found [name, type, prefix]: bannersqq, html, Administrator Under tour pop-up continues
Thank you Shirielle @sdwjoomla for the test. I confirm that URLs do validate even when the queries after the ? in the URL are wrong.
Another ping. The team would like to try to get this processed this weekend.
Another ping. The team would like to try to get this processed this weekend.
I have not found a good solution to this problem. I would appreciate if someone else with fresh eyes could take a look.
I have tested this item 🔴 unsuccessfully on 0c5c222
Go to System -> Manage section -> Guided Tours
Steps to recreate error:
Edit "How to create banners?" tour
Changed URL from administrator/index.php?option=com_banners&view=banners to administrator/index.php?option=com_banners&view=bannersqq
Save and Close
Run tour
An error has occurred.
404 View not found [name, type, prefix]: bannersqq, html, Administrator
Under tour pop-up continues
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44122.