PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Ruud68
Ruud68
18 Sep 2024

Pull Request for Issue # .
on a custom extension (com_dpdsm) that follows / extends / implements Joomla MVC I have enabled action logs by configuring the extension in table #__action_logs_extensions and #__action_log_config via the following installation queries:

INSERT INTO `#__action_logs_extensions` (extension) 
                SELECT 'com_dpdsm' 
                WHERE NOT EXISTS (SELECT 1 FROM `#__action_logs_extensions` WHERE extension = 'com_dpdsm');

and

INSERT INTO `#__action_log_config` (`type_title`, `type_alias`, `id_holder`, `title_holder`, `table_name`, `text_prefix`)
                SELECT 'datasubjectowner', 'com_dpdsm.datasubjectowner', 'id', 'name', '#__dpdsm_dso', 'COM_DPDSM_ACTIONLOG'
                WHERE NOT EXISTS (SELECT 1 FROM `#__action_log_config` WHERE `type_alias` = 'com_dpdsm.datasubjectowner');

In the component I can add / update / publish / unpublish / trash / delete / archive a so called Data Subject Owner.
These actions are correctly logged into the com_actionlogs listview

image

but the Latest Actions module is not rendiring the language strings added in the com_dpdsm language file for the action logs.

Summary of Changes

This PR loads all extenion language files configured to be used by the action logs component / plugins.

Testing Instructions

add action logging for your custom extension

Actual result BEFORE applying this Pull Request

Language string displayed as part of the message
image

Expected result AFTER applying this Pull Request

Language string correctly translated
image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Ruud68 Ruud68 - open - 18 Sep 2024
avatar Ruud68 Ruud68 - change - 18 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2024
Category Administration
avatar Hackwar Hackwar - change - 18 Sep 2024
Title
Action logs (module) not loading all languages
[5.2] Action logs (module) not loading all languages
avatar Hackwar Hackwar - edited - 18 Sep 2024
avatar Hackwar
Hackwar - comment - 18 Sep 2024

Since 5.1 doesn't get any additional releases anymore, I've changed this to 5.2-dev. If you can organise 2 people to successfully test this soon, then we can still get this into 5.2.

avatar Ruud68
Ruud68 - comment - 18 Sep 2024

Thanks @Hackwar ,
to be honest, as this method is already in since J3.9 I do not think I can find anybody who is actually using it for their extensions let alone to setup a test environment to test it.
IMO this is a simple / logic change that could do with a code review.
So anybody up for it / that?

avatar Quy Quy - change - 1 Nov 2024
Labels Added: PR-5.2-dev

Add a Comment

Login with GitHub to post a comment