[#44078] - [5.3][Performance] Access Rules smart preload, reduce memory use and time for large sites
- Pending
- Medium
- Build: 5.2-dev
- # 44078
- Diff
- Fedik:access-smart-preload
User tests: Successful: Unsuccessful:
Pull Request for Issue #43649.
Summary of Changes
Currently while checking access, the Access::preload() pulling everything from the access table.
It is neglectable for small sites, however for large sites it has huge impact on the site performance.
I added a new method for "smart preload", which allows to preload only needed items. And applied this method for most of the com_content views, where it make sense.
Testing Instructions
Create a site with 20k articles (more is better). Can use following plugin to generate random content https://github.com/Fedik/plg_sampledata_bigdata
Enable debug.
Open article detail or blog view.
Look for memory usage in the debug bar, and for time.
Actual result BEFORE applying this Pull Request
In my test:
memory usage around 45Mb
time 200-300ms
Expected result AFTER applying this Pull Request
In my test:
memory usage around ~12Mb
time ~100ms
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_content Front End Libraries |
| Labels |
Added:
Feature
bug
PR-5.2-dev
|
||
| Title |
|
||||||
Is it faster if you add these indexes?
ALTER TABLE `#__assets` ADD INDEX `idx_lft` (`lft`), ADD INDEX `idx_rgt` (`rgt`);
Nope, unfortunately. Before applying the index it took ~250ms, and after ~250ms.
It probably skipping index because of range check:
| Labels |
Added:
Performance
Removed: bug |
||
Will rebase it after upmarge