RTC PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Sep 2024

Remove the special check for language strings introduced in 4.0. No longer needed and strings are used elsewhere without this extra check

code review

avatar brianteeman brianteeman - open - 17 Sep 2024
avatar brianteeman brianteeman - change - 17 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2024
Category Layout
avatar brianteeman brianteeman - change - 17 Sep 2024
Labels Added: PR-5.3-dev
avatar richard67 richard67 - test_item - 17 Sep 2024 - Tested successfully
avatar richard67
richard67 - comment - 17 Sep 2024

I have tested this item ✅ successfully on ca2afd1

The strings were introduced with PR #34870 , so I agree that there was enough time to adjust translations.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44099.

avatar Quy Quy - test_item - 18 Sep 2024 - Tested successfully
avatar Quy
Quy - comment - 18 Sep 2024

I have tested this item ✅ successfully on ca2afd1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44099.

avatar Quy Quy - change - 18 Sep 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44099.

avatar laoneo laoneo - change - 18 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-18 06:25:17
Closed_By laoneo
Labels Added: RTC
avatar laoneo laoneo - close - 18 Sep 2024
avatar laoneo laoneo - merge - 18 Sep 2024
avatar laoneo
laoneo - comment - 18 Sep 2024

Thanks!

avatar brianteeman
brianteeman - comment - 18 Sep 2024

Thanks

Add a Comment

Login with GitHub to post a comment