User tests: Successful: Unsuccessful:
A list of tags is logically just that, a list, making a list element is the correct semantic choice for a containing element. Span makes no sense in this context and appears to have been used simply to render the tags inline.
Using the wrong element to achieve a certain visual appearance is bad.
This PR implements the correct html tag for the job at hand and throws list items inline using Bootstrap's purpose-made .inline class, saving on additional css.
Bootstrap's padding on inline-list elements is slightly greater than one letterspace (the whitespace that exists naturally between span elements), so tags will be spaced slightly further apart after this change.
This is actually beneficial because natural whitespace can be affected in unpredictable ways by, for example, extensions that minify the html. That would remove natural whitespace causing tags to smash into each other, something which would be prevented by this change.
Tested successfully, good change!
How to get the list? Just add some tags to an article, activate the display of tags in the options of the component and open the article in the frontend. Their you will see an inline list of all tags associated with this article.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
|Category||⇒||Tags Templates (site)|
|Status||Pending||⇒||Ready to Commit|
Test successful, small change in white space between tags as expected.
|Status||Ready to Commit||⇒||Closed|
|Closed_Date||0000-00-00 00:00:00||⇒||2014-10-08 06:49:09|