Feeling Lucky
Composer Dependency Changed
PR-5.2-dev
[#44037] - [5.2] sprintf as compiler optimized function
- Fixed in Code Base
- 11 Sep 2024
- Medium
- Build: 5.2-dev
- # 44037
- Diff
- tkuschel:5.2-phpcs-fix
User tests: Successful: Unsuccessful:
Preparation for an update of friendsofphp/php-cs-fixer v3.59.3 to v3.64.0
A compiler optimization has been added for sprintf in PHP 8.4.
Note: php 7.x, and older php 8.x is not affected by this.
Summary of Changes
Replace all sprintf with \sprintf ,
namespace { instead of
namespace
{
Testing Instructions
unit test with friendsofphp/php-cs-fixer v3.64.0
Actual result BEFORE applying this Pull Request
A test with friendsofphp/php-cs-fixer v3.64.0 fails,
Expected result AFTER applying this Pull Request
A test with friendsofphp/php-cs-fixer v3.64.0 passes.
Link to documentations
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_fields com_finder com_joomlaupdate com_menus com_newsfeeds com_users Repository Front End External Library Composer Change Libraries |
laoneo
- comment
- 10 Sep 2024
Its already there, in the root of the Repository
| Labels |
Added:
Composer Dependency Changed
PR-5.2-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-11 18:58:51 |
| Closed_By | ⇒ | Hackwar |
Thanks, can you ad the rule to the cs config file as this should be controlled as well
https://cs.symfony.com/doc/rules/function_notation/native_function_invocation.html