[#44036] - [5.2] UPD composer files, phpseclib/bcmath_compat 2.0.3
- Fixed in Code Base
- 11 Sep 2024
- Medium
- Build: 5.2-dev
- # 44036
- Diff
- tkuschel:5.2-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #44028 .
Updated composer files, b/c of fixed phpseclib/bcmath_compat#6
Summary of Changes
phpseclib/bcmath_compat from 2.0.2 to 2.0.3
The following 3 packages have also been updated as a side effect as expected:
maximebf/debugbar v1.22.3 to v1.22.4
friendsofphp/php-cs-fixer v3.59.3 to v3.64.0
phpstan/phpstan 1.12.0 to 1.12.2
Actual result BEFORE applying this Pull Request
bcmath_compat:
The exception ArgumentCountError gives wrong given parameter length. see phpseclib/bcmath_compat#6
for more details.
Expected result AFTER applying this Pull Request
Fixed
Link to documentations
- [X ] No documentation changes for docs.joomla.org needed
- [X ] No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | External Library Composer Change |
| Title |
|
||||||
What did I do wrong here that the build test "continuous-integration/dron/pr with phpcs failed? Is it correct that all files that are in the log file of the cs-fixer must be adjusted; so here in this case it is the sprintf which should be written as \sprintf, according to the phpcs.
@tkuschel If you check the changes in the composer.lock file from your PR, you will see that it doesn't only update the phpseclib/bcmath_compat dependency but also others, including the code style checker. I think that's the reason why it complains about unrelated files now. Maybe you have run a composer update (without any option) instead of composer update phpseclib/bcmath_compat for updating just that dependency?
| Labels |
Added:
Composer Dependency Changed
PR-5.2-dev
|
||
| Category | External Library Composer Change | ⇒ | Administration com_admin com_fields com_finder com_joomlaupdate com_menus com_newsfeeds com_users Repository Front End External Library Composer Change Libraries |
Thank you for the detailed description, I have corrected this.
It would have been better if you did what @richard67 said and ONLY updated bcmath with this PR.
Other changes such as phpcs and changing the sprintf should be in their own pull requests.
| Category | External Library Composer Change Administration com_admin com_fields com_finder com_joomlaupdate com_menus com_newsfeeds com_users Repository Front End Libraries | ⇒ | External Library Composer Change |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-11 17:21:28 |
| Closed_By | ⇒ | Hackwar |
What did I do wrong here that the build test "continuous-integration/dron/pr with phpcs failed?
Is it correct that all files that are in the log file of the cs-fixer must be adjusted; so here in this case it is the sprintf which should be written as \sprintf, according to the phpcs.