[#44026] - [5.2] [Guided Tours] Fix help link and add inlinehelp tag to the global settings of the Guided Tours
- Fixed in Code Base
- 11 Sep 2024
- Medium
- Build: 5.2-dev
- # 44026
- Diff
- obuisard:guided-tours-help
User tests: Successful: Unsuccessful:
Pull Request for Issue #44015.
Summary of Changes
The Guided Tours global settings are missing the inline help and the correct link to the user help.
This PR addressed that.
Testing Instructions
Go to Global Configuration -> Guided Tours under Joomla 5.2.
Actual result BEFORE applying this Pull Request
The help link goes to https://help.joomla.org/proxy?keyref=Help52:&lang=en
Expected result AFTER applying this Pull Request
The help link goes to https://help.joomla.org/proxy?keyref=Help52:Guided_Tours:_Options&lang=en.
The inline help button is visible and functional.
In both the before and after cases, the link results in a 404 page.
This is 'normal' for now that we are still in the beta phase for Joomla 5.2.
Try the link https://help.joomla.org/proxy?keyref=Help51:Guided_Tours:_Options&lang=en manually to confirm that the link will go to the right place once 5.2 is released.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Title |
|
||||||
you need to run the helptoc script as well
For me the Options language strings are missing:
COM_GUIDEDTOURS_CONFIG_USER_ALLOWTOURAUTOSTART_LABEL
COM_GUIDEDTOURS_CONFIG_USER_ALLOWTOURAUTOSTART_DESCRIPTION
COM_GUIDEDTOURS_CONFIG_DELAYED_TIME_LABEL
COM_GUIDEDTOURS_CONFIG_DELAYED_TIME_DESCRIPTION
Is that because I am testing on 5.1.4? The Help button works fine.
The Patchtester did not install properly on Joomla 5.2-dev. I get this error message:
1146 Table 'jcms5.uxeu9_patchtester_pulls_labels' doesn't exist
For me the Options language strings are missing: COM_GUIDEDTOURS_CONFIG_USER_ALLOWTOURAUTOSTART_LABEL COM_GUIDEDTOURS_CONFIG_USER_ALLOWTOURAUTOSTART_DESCRIPTION COM_GUIDEDTOURS_CONFIG_DELAYED_TIME_LABEL COM_GUIDEDTOURS_CONFIG_DELAYED_TIME_DESCRIPTION Is that because I am testing on 5.1.4? The Help button works fine.
The Patchtester did not install properly on Joomla 5.2-dev. I get this error message:
1146 Table 'jcms5.uxeu9_patchtester_pulls_labels' doesn't exist
Hi @ceford, "that because I am testing on 5.1.4?" I would assume so - I was testing on Joomla 5.2 ßeta 2+
For me the Options language strings are missing: COM_GUIDEDTOURS_CONFIG_USER_ALLOWTOURAUTOSTART_LABEL COM_GUIDEDTOURS_CONFIG_USER_ALLOWTOURAUTOSTART_DESCRIPTION COM_GUIDEDTOURS_CONFIG_DELAYED_TIME_LABEL COM_GUIDEDTOURS_CONFIG_DELAYED_TIME_DESCRIPTION Is that because I am testing on 5.1.4? The Help button works fine.
Yes, Cliff, the new parameters are present in Joomla 5.2. There were only user permissions before that.
you need to run the helptoc script as well
Hi Brian, this is not a new page, that page exists since Joomla 4.3. It just never had a proper link (!).
I have tested this item ✅ successfully on 4ae5a59
OK - I figures out how to run a test. And I have updated the screenshot in the Options Help page.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44026.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44026.
| Labels |
Added:
RTC
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-11 17:13:52 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
PR-5.2-dev
|
||
I have tested this item ✅ successfully on 4ae5a59
I have successfully tested this :)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44026.