User tests: Successful: Unsuccessful:
The core menu.js dynamically adds aria-hidden=true
attributes to ul
tags on menu level 2:
However, on focus and hover, these attributes aren't always set to "false" (which would be correct as the previously invisible dropdown now is possible) as the JS has a bug. It uses the target
attribute of the event, which is not the element that the eventhandler was bound to (=the parent <li>
) but the element that triggered the event, i.e. a nested a or span tag.
It should use currentTarget.
See msdn:
https://developer.mozilla.org/en-US/docs/Web/API/Event/currentTarget
Create a test site with a multi-level menu that uses the "default" menu layout. Make sure that the menu.js is loaded and the aria-hidden attribute is appended. Now hover over the element.
aria-hidden isn't updated reliably.
aria-hidden is updated reliably.
Please select:
Documentation link for docs.joomla.org:
[x ] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item ✅ successfully on 1dc9365
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
NPM Resource Changed
bug
PR-4.4-dev
|
RTC
Labels |
Added:
RTC
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-23 08:57:18 |
Closed_By | ⇒ | MacJoom |
Thank you!
I have tested this item ✅ successfully on 1dc9365
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44019.