RTC NPM Resource Changed bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar SniperSister
SniperSister
4 Sep 2024

Summary of Changes

The core menu.js dynamically adds aria-hidden=true attributes to ul tags on menu level 2:

Bildschirmfoto 2024-09-04 um 10 54 57

However, on focus and hover, these attributes aren't always set to "false" (which would be correct as the previously invisible dropdown now is possible) as the JS has a bug. It uses the target attribute of the event, which is not the element that the eventhandler was bound to (=the parent <li>) but the element that triggered the event, i.e. a nested a or span tag.

It should use currentTarget.

See msdn:
https://developer.mozilla.org/en-US/docs/Web/API/Event/currentTarget

Testing Instructions

Create a test site with a multi-level menu that uses the "default" menu layout. Make sure that the menu.js is loaded and the aria-hidden attribute is appended. Now hover over the element.

Actual result BEFORE applying this Pull Request

aria-hidden isn't updated reliably.

Expected result AFTER applying this Pull Request

aria-hidden is updated reliably.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

avatar SniperSister SniperSister - open - 4 Sep 2024
avatar SniperSister SniperSister - change - 4 Sep 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2024
Category JavaScript Repository NPM Change
avatar fgsw fgsw - test_item - 7 Sep 2024 - Tested successfully
avatar fgsw
fgsw - comment - 7 Sep 2024

I have tested this item ✅ successfully on 1dc9365


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44019.

avatar viocassel viocassel - test_item - 19 Sep 2024 - Tested successfully
avatar viocassel
viocassel - comment - 19 Sep 2024

I have tested this item ✅ successfully on 1dc9365


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44019.

avatar Quy Quy - change - 19 Sep 2024
The description was changed
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-4.4-dev
avatar Quy
Quy - comment - 19 Sep 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44019.

avatar Quy Quy - edited - 19 Sep 2024
avatar Quy Quy - change - 19 Sep 2024
Labels Added: RTC
avatar MacJoom MacJoom - change - 23 Sep 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-09-23 08:57:18
Closed_By MacJoom
avatar MacJoom MacJoom - close - 23 Sep 2024
avatar MacJoom MacJoom - merge - 23 Sep 2024
avatar MacJoom
MacJoom - comment - 23 Sep 2024

Thank you!

Add a Comment

Login with GitHub to post a comment