[#4399] - They seek him here, they seek him there! (a.k.a. Standardising tag layout positioning)
- Closed
- 31 Aug 2015
- Medium
- Build: staging
- # 4399
- Diff
- nternetinspired:layouts-tags
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
One layout style to rule them all
Currently the use of the tag layout and it's positioning varies greatly across com_content views, this PR standardises rendering and usage.
Example
If the article info is set to 'above' in article config, tags for an article appear above the document list in the category blog view, but below the document list in the article view.
If info position is set to 'below' tags still appear above the article intro in the category blog view, but in the article view they appear below the article content and also below the document list. In short, there is no standard use of this layout between these views.
Testing
After applying this patch tags should always appear above the document list as standard. They should also respect the above/below/split setting for article info in article, category blog and featured blog views.
jissues-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
brianteeman
- | Category | ⇒ | Layout Tags |
| Title |
|
||||||
Tried to test:
1) "If the article info is set to 'above' in article config, tags for an article appear above the document list in the category blog view, but below the document list in the article view."
-> before applying it by setting it to 'above', it showed the info everytime above. It wasn't shown below the document list in the article view like described.
2) "If info position is set to 'below' tags still appear above the article intro in the category blog view, but in the article view they appear below the article content and also below the document list. In short, there is no standard use of this layout between these views."
-> that's true.
3) After applying this patch tags should always appear above the document list as standard. They should also respect the above/below/split setting for article info in article, category blog and featured blog views.
-> couldn't recognize any changes (yes, I checked, if it was applied successfully)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4399.
After the patch was applied, the tags were shown above as standard. If I changed it to below or split there were shown as specified before. Test was successful!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4399.
@nternetinspired can you please fix the conflicts, so we can continue with this issue? Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4399.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-08-31 11:26:54 |
| Closed_By | ⇒ | nternetinspired |
In split view the tags are at the bottom - Otherwise they are always above the "Details" blog. But overall tested successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4399.