Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4398] - [fix] error when adding tags with keyboard. Fixes #4394

? Success

User tests: Successful: Unsuccessful:

avatar phproberto
phproberto
30 Sep 2014

This fixes the issue described in:
#4394

This was introduced in: 88ed53e#diff-0fe9e3814af6ea886d29a21726738a2aR166

Apparently minTermLength fix from @davidhurley's didn't include a default value for the setting. So it was using 0 as minimum length (until you save the com_params config). I added an extra this.value check to be sure that an empty tag is never going to be added even if someone manages to use 0 as minTermLength (which should not be possible because the minimum in config is 1).

avatar phproberto phproberto - open - 30 Sep 2014
avatar jissues-bot jissues-bot - change - 30 Sep 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 30 Sep 2014
Category ⇒ Tags
avatar roland-d
roland-d - comment - 30 Sep 2014

@test: After applying the patch, I can save the article after adding a tag using Enter.

avatar rdeutz rdeutz - test_item - 30 Sep 2014 - Tested successfully
avatar roland-d roland-d - test_item - 30 Sep 2014 - Tested successfully
avatar roland-d roland-d - change - 30 Sep 2014
Status Pending ⇒ Ready to Commit
avatar mbabker mbabker - change - 30 Sep 2014
Status Ready to Commit ⇒ Fixed in Code Base
avatar mbabker mbabker - close - 30 Sep 2014
avatar mbabker mbabker - change - 30 Sep 2014
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-09-30 20:19:50
avatar mbabker
mbabker - comment - 30 Sep 2014

Fixed via 9da927e

Add a Comment

Login with GitHub to post a comment