RTC b/c break PR-6.0-dev Pending

User tests: Successful: 0 Unsuccessful: 0

avatar Quy
Quy
21 Aug 2024

Summary of Changes

Per comment, remove obsolete code.

Documentation

Manual Update: joomla/Manual#321

Testing Instructions

Code review.

avatar Quy Quy - open - 21 Aug 2024
avatar Quy Quy - change - 21 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2024
Category Libraries
avatar ChristineWk ChristineWk - test_item - 21 Aug 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 21 Aug 2024

I have tested this item ✅ successfully on 45c0c0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43959.

avatar sandewt sandewt - test_item - 22 Aug 2024 - Tested successfully
avatar sandewt
sandewt - comment - 22 Aug 2024

I have tested this item ✅ successfully on 45c0c0c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43959.

avatar laoneo
laoneo - comment - 22 Aug 2024

This needs to go into 6.0 as it is a bc break.

avatar Fedik
Fedik - comment - 22 Aug 2024

Per comment, remove obsolete code.

It was for 5.0, but cannot go into 5.x. It can go to 6.0, but cannot go into 6.x ?

avatar Quy Quy - change - 24 Aug 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-08-24 12:53:58
Closed_By Quy
Labels Added: b/c break PR-5.2-dev
avatar Quy Quy - close - 24 Aug 2024
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2024
Category Libraries Administration com_associations com_categories com_config com_contact com_content com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_postinstall com_tags com_templates com_users com_workflow Language & Strings
avatar Quy Quy - change - 11 Oct 2024
Status Closed New
Closed_Date 2024-08-24 12:53:58
Closed_By Quy
Labels Added: Language Change PR-6.0-dev
avatar Quy Quy - change - 11 Oct 2024
Status New Pending
avatar Quy Quy - reopen - 11 Oct 2024
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2024
Category Administration com_associations com_categories com_config com_contact com_content com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_postinstall com_tags com_templates com_users com_workflow Language & Strings Libraries
avatar Quy Quy - change - 11 Oct 2024
Labels Removed: Language Change
avatar Quy Quy - change - 11 Oct 2024
Title
[5.2] Remove obsolete code
[6.0] Remove obsolete code
avatar Quy Quy - edited - 11 Oct 2024
avatar Fedik
Fedik - comment - 11 Oct 2024

One more thing.
The following properties also should be removed with this PR:

 protected static $gmt;
 protected static $stz;

They not in use by core, but were kept for backward compatibility.
See the original PR #29270

avatar Quy Quy - change - 11 Oct 2024
Labels Removed: PR-5.2-dev
avatar fgsw fgsw - test_item - 12 Oct 2024 - Tested successfully
avatar fgsw
fgsw - comment - 12 Oct 2024

I have tested this item ✅ successfully on 73d7d4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43959.

avatar ChristineWk ChristineWk - test_item - 12 Oct 2024 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 12 Oct 2024

I have tested this item ✅ successfully on 73d7d4d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43959.

avatar Quy Quy - change - 12 Oct 2024
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Oct 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43959.

avatar Quy Quy - change - 18 Oct 2024
Labels Added: RTC
avatar HLeithner HLeithner - change - 19 Oct 2024
The description was changed
avatar HLeithner HLeithner - edited - 19 Oct 2024
avatar HLeithner HLeithner - change - 19 Oct 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-10-19 10:36:21
Closed_By HLeithner
avatar HLeithner HLeithner - close - 19 Oct 2024
avatar HLeithner HLeithner - merge - 19 Oct 2024
avatar HLeithner
HLeithner - comment - 19 Oct 2024

thanks

Add a Comment

Login with GitHub to post a comment