Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#43958] - [5.3] Refactoring from CMS Folder to framework Folder class

Maintainers Checked PR-5.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
21 Aug 2024

Summary of Changes

What the title says. Right now this is still a draft.

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Hackwar Hackwar - open - 21 Aug 2024
avatar Hackwar Hackwar - change - 21 Aug 2024
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2024
Category ⇒ Administration com_config com_installer com_languages com_menus com_templates Installation Libraries Front End Plugins
avatar Hackwar Hackwar - change - 21 Aug 2024
Labels Added: PR-5.2-dev
avatar Fedik
Fedik - comment - 22 Aug 2024

Maybe try to log the response, to get more insfo where the exceptions actualy comes.
Try

joomla-cms/tests/System/integration/api/com_media/Files.cy.js

Line 169 in 2299e66

.then(() => cy.api_delete('/media/files/test-dir/todelete'));

Change to

.then(() => cy.api_delete('/media/files/test-dir/todelete')).then((response) => {
  cy.log(response.body);
  cy.log(response.status);
});

In theory should print response JSON on the error screenshot, but I cannot test.

4abf40a 24 Aug 2024 avatar Hackwar cs
avatar Hackwar
Hackwar - comment - 29 Aug 2024

As much as I'd like to see this in 5.2, I'm going to move this to 5.3. There just isn't enough time right now.

avatar Hackwar Hackwar - change - 29 Aug 2024
Title
…
[5.2] Refactoring from CMS Folder to framework Folder class
[5.3] Refactoring from CMS Folder to framework Folder class
avatar Hackwar Hackwar - edited - 29 Aug 2024
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2024
Category Administration com_config com_installer com_languages com_menus com_templates Installation Libraries Front End Plugins ⇒ Administration com_config com_content com_installer com_languages com_media com_menus com_templates Language & Strings Repository NPM Change Front End com_contact com_newsfeeds com_tags Installation Libraries
avatar Hackwar Hackwar - change - 12 Sep 2024
Labels Added: Language Change NPM Resource Changed PR-5.3-dev
Removed: PR-5.2-dev
avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2024
Category Administration com_config com_installer com_languages com_menus com_templates Installation Libraries Front End com_content com_media Language & Strings Repository NPM Change com_contact com_newsfeeds com_tags ⇒ Administration com_config com_content com_installer com_languages com_media com_menus com_templates Language & Strings Repository NPM Change Front End com_contact com_newsfeeds com_tags External Library Composer Change Installation Libraries
avatar Hackwar Hackwar - change - 12 Sep 2024
Labels Added: Composer Dependency Changed
avatar joomla-cms-bot joomla-cms-bot - change - 12 Sep 2024
Category Administration com_config com_installer com_languages com_menus com_templates Installation Libraries Front End com_content com_media Language & Strings Repository NPM Change com_contact com_newsfeeds com_tags External Library Composer Change ⇒ Administration com_config com_installer com_languages com_menus com_templates External Library Composer Change Installation Libraries Front End Plugins
avatar rdeutz rdeutz - change - 18 Sep 2024
Labels Removed: Language Change NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2024
Category Administration com_config com_installer com_languages com_menus com_templates Installation Libraries Front End External Library Composer Change Plugins ⇒ Administration com_config com_installer com_languages com_menus com_templates Installation Libraries Front End Plugins
avatar rdeutz
rdeutz - comment - 18 Sep 2024

Looks good to me

avatar laoneo laoneo - change - 5 Oct 2024
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2024-10-05 12:02:36
Closed_By ⇒ laoneo
Labels Added: Maintainers Checked
Removed: Composer Dependency Changed
avatar laoneo laoneo - close - 5 Oct 2024
avatar laoneo laoneo - merge - 5 Oct 2024
avatar laoneo
laoneo - comment - 5 Oct 2024

Thanks!

Add a Comment

Login with GitHub to post a comment