Feeling Lucky

[#4394] - Save article failed (empty title), when selecting a tag with the keyboard.

No Code Attached Yet
avatar dneukirchen
dneukirchen
30 Sep 2014

Steps to reproduce the issue

Create a tag
Create an article
Fill in the title
Fill in the content
Select the tag with the keyboard (enter key, not the mouse).
Save the article.

Expected result

The article should be saved.

Actual result

Error
Save failed with the following error: The title is empty

System information (as much as possible)

Apache/2.4.10 (Ubuntu)
PHP 5.5
Joomla! 3.3.4 Stable
Google Chrome (Version 37.0.2062.124)

Additional comments

It only happens, when you select the tag with your keyboard.

Some others are facing the same issue:
Google Groups
Joomla Forums

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00

avatar dneukirchen dneukirchen - open - 30 Sep 2014
avatar phproberto
phproberto - comment - 30 Sep 2014

I was able to reproduce this. Apparently a new empty tag is being added to the options when selecting the tag with the keyboard:

<option value="#new#" selected="selected"></option>

Tested on Firefox v32.0.3

I also tested this on and old v3.3.0 and it's working fine



This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar dneukirchen
dneukirchen - comment - 30 Sep 2014

Im looking into this in detail this evening.
The Issue is caused by the script in joomla-cms/cms/html/tag.php.

In my opinion that script needs refactoring not only because of the "saving article" bug.
The intended behaviour (select tag with keyboard, add new/custom tag with enter OR comma key) is not working properly (for instance: you cant add a custom tag, which begins with the same characters as an existing one).


This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar phproberto
phproberto - comment - 30 Sep 2014

Please check #4398

The intended behaviour (select tag with keyboard, add new/custom tag with enter OR comma key) is not working properly (for instance: you cant add a custom tag, which begins with the same characters as an existing one).

Yes you can but to discard the proposed options you have to click the "up arrow".

avatar dneukirchen
dneukirchen - comment - 30 Sep 2014

Good job. I´ll test the fix later.
Nevertheless we could make some improvements to the script (i dont want to add a new tracker item for that).

1) When you add a new tag with comma, the comma doesnt get removed from the tag name ("myTag," instead of "myTag").

2) (Not that important). Change the chosen "no_results_text" to something that describes the possibility to add new tags with enter or comma. Chosen Documentation

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar zero-24 zero-24 - close - 1 Oct 2014
avatar phproberto phproberto - close - 1 Oct 2014
avatar phproberto phproberto - change - 1 Oct 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-09-30 20:19:49
avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: No Code Attached Yet

Add a Comment

Login with GitHub to post a comment