Feature Language Change NPM Resource Changed PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Aug 2024

Pull Request for Issue # .

Summary of Changes

The majority of changes with 7.x do not impact us as they are for the premium version and the premium plugins. Other changes are really just bug fixes and accessibility improvements.

The full changelog for the open source release of tinymce can be found here

Set tinymce to be used under the gpl licence. https://www.tiny.cloud/docs/tinymce/latest/license-key/#use-tinymce-with-the-gplv2-license - without this change a console warning is displayed

The one change that does need testing is sandbox_iframes

Testing Instructions

  1. Test all editor-xtd buttons

  2. Test the source code editor
    image

  3. Test any third party plugin eg https://github.com/brianteeman/slashtools
    This uses one of the few breaking changes so should fail https://www.tiny.cloud/docs/tinymce/latest/migration-from-6x/#the-autocompleter-ch-configuration-property-has-been-removed-use-the-trigger-property-instead I will make a new release of it but I am not aware of any other plugin using this.

  4. Test drag and drop images

  5. Test content templates
    image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2024
Category NPM Change Front End Plugins
avatar brianteeman brianteeman - open - 12 Aug 2024
avatar brianteeman brianteeman - change - 12 Aug 2024
Status New Pending
avatar brianteeman brianteeman - change - 12 Aug 2024
Labels Added: NPM Resource Changed PR-5.2-dev
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
3f7ce26 12 Aug 2024 avatar brianteeman gpl
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar bembelimen
bembelimen - comment - 12 Aug 2024

Hey @brianteeman , not sure if this answers your question, but the idea for the sandbox_iframes parameter was: when we go to TinyMCE 7 it should still stay at "true", so all entries get sandboxed by default (and the plugin parameter we added to disable it could be removed) but additionally the current domain should be allowed via: sandbox-iframes-exclusions.
Also an extra field should be added, where people can add more domains to allow them.

One concern is, how to prevent, that people open the joomla installation with another domain and add iframes for this domain (as it's then allowed automatically).

avatar brianteeman
brianteeman - comment - 12 Aug 2024

Thanks, that answers most of it I think. Will add the exclusion field

avatar joomla-cms-bot joomla-cms-bot - change - 12 Aug 2024
Category NPM Change Front End Plugins Administration Language & Strings NPM Change Front End Plugins
avatar brianteeman brianteeman - change - 12 Aug 2024
Labels Added: Language Change
avatar dgrammatiko
dgrammatiko - comment - 12 Aug 2024

@brianteeman @bembelimen according to their docs you shouldn't expose the switch to turn on/off the sandboxing as an empty array is doing exactly that: To enable [sandboxing](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe#sandbox) on all iframes, set this option to an empty array [].

In sort the sandbox_iframes_exclusions should be an array with default value the value of tinymce (is given in the link above):

[
  'youtube.com',
  'youtu.be',
  'vimeo.com',
  'player.vimeo.com',
  'dailymotion.com',
  'embed.music.apple.com',
  'open.spotify.com',
  'giphy.com',
  'dai.ly',
  'codepen.io'
]
avatar brianteeman
brianteeman - comment - 12 Aug 2024

yes I know. I am still working on it (or will be tonight when care duties end) or you can submit a pr to this draft branch ;)

d5fd566 12 Aug 2024 avatar brianteeman wip
avatar brianteeman brianteeman - change - 12 Aug 2024
The description was changed
avatar brianteeman brianteeman - edited - 12 Aug 2024
avatar brianteeman
brianteeman - comment - 12 Aug 2024

@bembelimen I think I got it correct now

dd36ea1 12 Aug 2024 avatar brianteeman cs
0f574de 12 Aug 2024 avatar brianteeman cs
avatar Quy
Quy - comment - 13 Aug 2024

Should it be only the domain name without http?

avatar brianteeman
brianteeman - comment - 13 Aug 2024

Should it be only the domain name without http?

??

avatar Quy
Quy - comment - 13 Aug 2024

These are listed without http. Should the additional values be host names or domain names (without http)?

[
  'youtube.com',
  'youtu.be',
  'vimeo.com',
  'player.vimeo.com',
  'dailymotion.com',
  'embed.music.apple.com',
  'open.spotify.com',
  'giphy.com',
  'dai.ly',
  'codepen.io'
]
avatar brianteeman
brianteeman - comment - 13 Aug 2024

These are listed without http. Should the additional values be host names or domain names (without http)?

[
  'youtube.com',
  'youtu.be',
  'vimeo.com',
  'player.vimeo.com',
  'dailymotion.com',
  'embed.music.apple.com',
  'open.spotify.com',
  'giphy.com',
  'dai.ly',
  'codepen.io'
]

The current domain and this list of common domains are excluded by default.

avatar Quy
Quy - comment - 13 Aug 2024

Yes, I understand. but when adding new ones to the exclusions list, there is a hint https:// so maybe it can be interpreted to prefix it with https://.

avatar brianteeman
brianteeman - comment - 13 Aug 2024

I understand you now. Thanks for your perseverance I will look into it in the morning

avatar brianteeman
brianteeman - comment - 30 Aug 2024

Note to self
Review the skins and themes https://www.tiny.cloud/docs/tinymce/latest/customize-ui/

avatar HLeithner
HLeithner - comment - 2 Sep 2024

I rebase this for now to 5.3 (actually 6.0 should be the target), since it's late in the cycle and actually it might be a b/c break if tinymce follows semver. If maintainers/production has finally discussed this a rebase to 5.2 is possible.
So please don't update the branch to 5.3 code

avatar brianteeman
brianteeman - comment - 2 Sep 2024

@HLeithner I specifically asked which version to make this for and was told #43110 (comment) - please make up your minds

avatar brianteeman brianteeman - change - 2 Sep 2024
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2024-09-02 07:56:13
Closed_By brianteeman
Labels Added: Feature
avatar brianteeman brianteeman - close - 2 Sep 2024
avatar joomla-cms-bot joomla-cms-bot - change - 2 Sep 2024
Category NPM Change Front End Plugins Administration Language & Strings Administration SQL com_admin Postgresql com_content com_media com_users Language & Strings Repository NPM Change JavaScript Front End com_contact com_newsfeeds com_tags Installation

Add a Comment

Login with GitHub to post a comment