Feeling Lucky
PR-5.1-dev
[#43899] - Incorrect file size validation in media manager
- Closed
- 11 Aug 2024
- Medium
- Build: 5.1-dev
- # 43899
- Diff
- brianteeman:base64fix
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
PR for #43387
the Base64 version of a string or file is typically roughly a third larger than its source so this adds a 1.33 factor to the size calculation
See #43387 and https://developer.mozilla.org/en-US/docs/Glossary/Base64#encoded_size_increase for more information
Test instructions
- media manager set to 4mb
Try to upload a file just below 4mb in size
Before
Image is rejected as too large
After
Image is accepted
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Labels |
Added:
PR-5.1-dev
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-11 08:48:55 |
| Closed_By | ⇒ | brianteeman |
brianteeman
- comment
- 11 Aug 2024
Moved to 4.4 as requested
@brianteeman Shouldn't that PR be made for 4.4-dev? The issue was initially reported for 4.4.