RTC Language Change PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
9 Aug 2024

Summary of Changes

Took me a while to work out why I did not see any field to select a file attachment to go with my mail templates. The problem was that you have to define the folder in the component option first or the field is never displayed.
Check that the mail template options has a blank entry for the attachments folder
Open any mail template and there is nowhere to attach a field
Change the mail template options entry for the attachments folder to any valid folder on the server
Open any mail template and scroll to the bottom and you will see the abilility to attach a field

Testing Instructions

Go to the mail template options and click on the Toggle Inline Help button

Actual result BEFORE applying this Pull Request

"Provide a relative path from the root of your installation to the folder containing files that you want to attach to the mails."

image

Expected result AFTER applying this Pull Request

"Provide a relative path from the root of your installation to the folder containing files that you want to attach to the mails. If left blank then the attachments option will not be available in the mail template."

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Notes

I made this as a PR to 5.2 as its more extensive a language string change than simply grammar or spelling but maybe maintainers want to merge it into an earlier release

avatar brianteeman brianteeman - open - 9 Aug 2024
avatar brianteeman brianteeman - change - 9 Aug 2024
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2024
Category Administration Language & Strings
avatar fgsw fgsw - test_item - 9 Aug 2024 - Tested successfully
avatar fgsw
fgsw - comment - 9 Aug 2024

I have tested this item ✅ successfully on 110ea3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898.

avatar Quy Quy - test_item - 9 Aug 2024 - Tested successfully
avatar Quy
Quy - comment - 9 Aug 2024

I have tested this item ✅ successfully on 110ea3c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898.

avatar Quy Quy - change - 9 Aug 2024
Status Pending Ready to Commit
Labels Added: Language Change PR-5.2-dev
avatar Quy
Quy - comment - 9 Aug 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43898.

avatar wilsonge wilsonge - change - 9 Aug 2024
Labels Added: RTC
avatar wilsonge wilsonge - change - 9 Aug 2024
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-09 14:10:13
Closed_By wilsonge
avatar wilsonge wilsonge - close - 9 Aug 2024
avatar wilsonge wilsonge - merge - 9 Aug 2024
avatar brianteeman
brianteeman - comment - 9 Aug 2024

Thansks @wilsonge

avatar wilsonge
wilsonge - comment - 9 Aug 2024

Thanks!

Add a Comment

Login with GitHub to post a comment