? Success

User tests: Successful: Unsuccessful:

avatar chrisdavenport
chrisdavenport
28 Sep 2014

This might not work initially because there are some changes that need to be done on the wiki too.

avatar chrisdavenport chrisdavenport - open - 28 Sep 2014
avatar jissues-bot jissues-bot - change - 28 Sep 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 28 Sep 2014

@chrisdavenport the result after the patch is:

http://docs.joomla.org/Help33:Joomla_Version_3_3_4/en that don't contain any content. The content is at http://docs.joomla.org/Help33:Joomla_Version_3_3_4 for me.

avatar zero-24
zero-24 - comment - 28 Sep 2014

hehe I should read your comment too. Sorry @chrisdavenport

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar zero-24 zero-24 - change - 28 Sep 2014
Category Administration Multilanguage UI/UX
avatar Hutchy68
Hutchy68 - comment - 28 Sep 2014

@zero-24 it should work now. All we are really testing for is /en appended to the url.

avatar zero-24
zero-24 - comment - 28 Sep 2014

@Hutchy68 @chrisdavenport it works now for english but is it possible to fallback to english if there is no for the current language?

Example http://docs.joomla.org/Help33:Joomla_Version_3_3_4/nl and http://docs.joomla.org/Help33:Joomla_Version_3_3_4/de

avatar chrisdavenport
chrisdavenport - comment - 28 Sep 2014

@zero-24 Possibly. I need to make some changes in the proxy for that to work. We're looking into it.

avatar zero-24
zero-24 - comment - 28 Sep 2014
avatar infograf768
infograf768 - comment - 29 Sep 2014

ATM, I do not get a lang prefix
I get in the help modal
http://help.joomla.org/proxy/index.php?option=com_help&keyref=Help33:Site_System_Information
How to test that the prefix is added?

avatar zero-24
zero-24 - comment - 29 Sep 2014

@infograf768 this only affect the version check.

avatar mbabker
mbabker - comment - 29 Sep 2014

I've merged this into 3.4-dev which will allow time for it to be tested and any backend structures updated prior to 3.4's release.

Thanks!

avatar mbabker mbabker - close - 29 Sep 2014
avatar mbabker mbabker - change - 29 Sep 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-09-29 14:59:36
avatar mbabker mbabker - change - 29 Sep 2014
Status Closed Fixed in Code Base
avatar zero-24
zero-24 - comment - 29 Sep 2014

@mbabker this break atm (if nothing is changed at the proxy) all non english backends that use the Joomla Help Version check.

avatar mbabker
mbabker - comment - 29 Sep 2014

Since it's on the development branch and the problem code is within our own infrastructure, this is OK for the moment. If we get to the beta stage and it's not fixed, we can look at reverting it out.

avatar zero-24
zero-24 - comment - 29 Sep 2014

ok.

avatar chrisdavenport
chrisdavenport - comment - 1 Oct 2014

This should be working now. Please make sure that the version check still works in English. With a non-English language, if there is no wiki page for that language it should fall back to the English page. However, the language selection should be propagated so clicking on a link in the English page will still take you to the non-English page associated with that link, if it exists.

avatar zero-24
zero-24 - comment - 2 Oct 2014

thanks @chrisdavenport I have misunderstand you. I understand that you need to change something at the router in the CMS :+1:

@test success using de-DE langauage pack :+1: (en-GB version is shown)

@chrisdavenport have we a translation that can be tested?

avatar chrisdavenport
chrisdavenport - comment - 2 Oct 2014

The Dutch (nl) page has been partially translated now, so you can test with that.

avatar zero-24
zero-24 - comment - 2 Oct 2014

thanks @chrisdavenport

it works for me (using 3.3.4 via version.php as 3.3.6 is not translated yet)
nl-NL --> translated version available --> nl-NL version
de-DE --> no translated version available --> en-GB version
en-GB --> original --> en-GB version

thanks @chrisdavenport and @Hutchy68

Add a Comment

Login with GitHub to post a comment