[#4379] - Use GMT localtime only if localzone is not set
- Closed
- 29 Sep 2014
- Medium
- Build: staging
- # 4379
- Diff
- fastslack:date-fix
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
If we try to get the current date using JDate, for example:
$date = new JDate();
$date->format('H:i:s')
This example return the current time but using the GMT timezone and not using the saved into the Joomla! configuration (in my case 'America/Argentina/Buenos_Aires' GMT-3).
With the current patch, this bug is fixed.
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
Running travis to upstream/staging without any changes:
$ phpunit --configuration travisci-phpunit.xml
PHPUnit 3.7.28 by Sebastian Bergmann.
Configuration read from /home/fastslack/www/joomla-dev/travisci-phpunit.xml
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSIISSSSSSSSSSSSSIIIIIIISSSSS..III 61 / 5939 ( 1%)
IIIIIIISSI.ESSSSS.SSI...SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 122 / 5939 ( 2%)
SSSSSSSSSSIIIIIISSSS........................I..I..IIIIIII.I.I 183 / 5939 ( 3%)
.I.I.I..III....IIIIIIIIIIIIIII...IIIIIIIIEIII..SSSSSSSSSSS... 244 / 5939 ( 4%)
..............II...III....IIIII..II.......................... 305 / 5939 ( 5%)
..................................I.I.SI.SS...I.............I 366 / 5939 ( 6%)
...IIIIIIIIIIIIIIISSSSS...........F..F..........F.......S.... 427 / 5939 ( 7%)
....SSSS............IIIIIII....IIIIIIIII....IIIIIII....II..SS 488 / 5939 ( 8%)
SISSSSSSSSSS.......I...EE..SS..I.III.I.SSSSSSSSS........I.... 549 / 5939 ( 9%)
....................................................SSSSSSSSS 610 / 5939 ( 10%)
SSSSSSSSSSSSSSSSSSSSSSS......EEEEEEEEEE
The errors still there, seems that this change is not related with that.
The last build on the staging branch (https://travis-ci.org/joomla/joomla-cms/builds/36435395) passed just fine.
Also, I have no idea if the test suite will even run properly against 3.7 anymore. We're using a mix of 4.1 and 4.2 across the CI environments.
Hmm i downloaded phunit 4.2 and the problem still there:
[fastslack@escorpio:/home/fastslack/www]
$ git clone git@github.com:joomla/joomla-cms.git travis
Cloning into 'travis'...
remote: Counting objects: 413320, done.
remote: Total 413320 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (413320/413320), 111.24 MiB | 1.17 MiB/s, done.
Resolving deltas: 100% (289550/289550), done.
Checking connectivity... done.
[fastslack@escorpio:/home/fastslack/www]
$ cd travis/
[fastslack@escorpio:/home/fastslack/www/travis]
$ cp ../phpunit.phar . <=== Copy phpunit 4.2
[fastslack@escorpio:/home/fastslack/www/travis]
$ php phpunit.phar --configuration travisci-phpunit.xml
PHPUnit 4.2.6 by Sebastian Bergmann.
Configuration read from /home/fastslack/www/travis/travisci-phpunit.xml
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSIISSSSSSSSSSSSSIIIIIIISSSSS..III 61 / 5939 ( 1%)
IIIIIIISSI.ESSSSS.SSI...SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS 122 / 5939 ( 2%)
SSSSSSSSSSIIIIIISSSS........................I..I..IIIIIII.I.I 183 / 5939 ( 3%)
.I.I.I..III....IIIIIIIIIIIIIII...IIIIIIIIEIII..SSSSSSSSSSS... 244 / 5939 ( 4%)
..............II...III....IIIII..II.......................... 305 / 5939 ( 5%)
.................................EIEI.SI.SS...I.............I 366 / 5939 ( 6%)
...IIIIIIIIIIIIIIISSSSS...........E..E........E.E.......S.... 427 / 5939 ( 7%)
....SSSS............IIIIIII....IIIIIIIII....IIIIIII....II..SS 488 / 5939 ( 8%)
SISSSSSSSSSS.......I...EE..SS..I.III.I.SSSSSSSSS........I..E. 549 / 5939 ( 9%)
....................................................SSSSSSSSS 610 / 5939 ( 10%)
SSSSSSSSSSSSSSSSSSSSSSS......EEEEEEEEEE
You're getting different errors. The ones from this PR start after 1400 tests, your's are starting much sooner.
Shouldn't we be using UTC now and not GMT?
http://en.wikipedia.org/wiki/Coordinated_Universal_Time
"Time zones around the world are expressed as positive or negative offsets from UTC, as in the list of time zones by UTC offset.
UTC is used in many Internet and World Wide Web standards. The Network Time Protocol, designed to synchronise the clocks of computers over the Internet, encodes times using the UTC system.[12]
Computer servers, online services and other entities that rely on having a universally accepted time use UTC as it is more specific than GMT. If only limited precision is needed, clients can obtain the current UTC from a number of official Internet UTC servers. For sub-microsecond precision, clients can obtain the time from satellite signals.
UTC is also the time standard used in aviation,[13] e.g., for flight plans and air traffic control clearances. Weather forecasts and maps all use UTC to avoid confusion about time zones and daylight saving time. "
Hils
Thanks Brian - so why is GMT mentioned in this PR? is it because of this? :
http://de2.php.net/manual/en/function.gmdate.php
PS - ignore me if it is a dumb question, I know this isn't the place for education sorry!
Because GMT and UTC are functionally the same people often swap the names.
The fact is that the TEXT in global config is UTC so your original post is
not relevant
On 28 Sep 2014 19:58, "Hils" notifications@github.com wrote:
PS - ignore me if it is a dumb question, I know this isn't the place for
education sorry!—
Reply to this email directly or view it on GitHub
#4379 (comment).
Thanks again Brian
"the TEXT in global config is UTC" - yes & good
Hopefull soon UTC will be used throughout the code & text at some point.
Eventually my post might be relevant ;)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-29 01:01:20 |
@fastslack
Travis fails 40 times:
https://travis-ci.org/joomla/joomla-cms/jobs/36493876