[#43784] - [4][com_scheduler] Manual Execution Rule blocks Lazy and Webcron
- Fixed in Code Base
- 12 Sep 2024
- Medium
- Build: 4.4-dev
- # 43784
- Diff
- alikon:patch-21
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #43767 .
Summary of Changes
Testing Instructions
see #43767
Actual result BEFORE applying this Pull Request
no task is executed if there is one Manual
Expected result AFTER applying this Pull Request
task is executed even if there is a Manual task
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration |
| Labels |
Added:
PR-4.4-dev
|
||
Hi,
I went through the different scenarios and all seems to work fine now.
Nice work, you reshuffled quite a bit code, don't like the 'clone' :)
A bit beyond this fix; Locking remains an issue. If a task crashes the whole cue get's locked. And i can't even force a run (or run an unlock task) since neither the CLI nor the WebCron pass the allowConcurrent option.
I have some thought about that: #43775
I have tested this item ✅ successfully on 1737666
Works well, good catch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43784.
I have tested this item ✅ successfully on 1737666
It works for me.
I have setup 1 manual task, 1 every minute and 1 every 2 minutes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43784.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43784.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-09-12 08:04:17 |
| Closed_By | ⇒ | laoneo | |
| Labels |
Added:
RTC
bug
|
||
Thanks!
I was wondering, wouldn't it be safer for future changes to clone the lockQuery
$idQuery= clone $lockQuery; // and move the $lockQuery->update part down.
This ensures that the conditions for idquery are always the same. And saves some code.
And I got a different issue while testing. If you trash a locked/running task, it blocks execution, since $lockCountQuery does not ignore trashed tasks.